search

divio / aldryn-search

Haystack 2.0 search index for django CMS
Other
48 stars 77 forks source link

Django 2 compatibility #97

Closed febsn closed 5 years ago

febsn commented 5 years ago

user.is_authenticated is a property from Django 1.10 upwards, support for calling it as a method was removed in Django 2.0.

This pull request is incompatible with Django<1.10, which shouldn't be a problem since Django<1.11 is now unsupported anyway (might still be worth a note/dependency?).

codecov-io commented 5 years ago

Codecov Report

Merging #97 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   58.64%   58.64%           
=======================================
  Files          14       14           
  Lines         457      457           
  Branches       49       49           
=======================================
  Hits          268      268           
  Misses        168      168           
  Partials       21       21
Impacted Files Coverage Δ
aldryn_search/views.py 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aec54a1...b74d3ba. Read the comment docs.

DmytroLitvinov commented 5 years ago

Hello @FinalAngel.

I could improve this PR and prepare repo for deprecation of Django<1.11. Please let me know if it is ok for you. Because we really need to support only Django>=1.11

P.s. Link for deprecation about which author speaks: https://docs.djangoproject.com/en/1.11/ref/contrib/auth/#django.contrib.auth.models.User.is_authenticated

DmytroLitvinov commented 5 years ago

@FinalAngel this PR can be closed because https://github.com/divio/aldryn-search/pull/98 already merged today.