Remove Unused Dependency: Attrs

gdrosos commented 1 year ago

Summary

This pull request removes the unused dependency attrs from the requirements.txt file. This detection and removal is a finding from ongoing research aimed at identifying and eliminating code bloat within software projects.

Rationale

The attrs package was added in this commit, but upon analysis of the codebase, it was found that it is not currently being utilized within the project. Removing this unused dependency can reduce the overall footprint of the application, mitigate potential security risks, and simplify the dependency management process.

Changes

Removed the dependency to the attrs PyPI package from the requirements.txt file.

Impact

Reduced package size: The removal of this unused dependency will lead to a decrease in the overall size of the installed packages.
Simplified dependency tree: Fewer dependencies make the project easier to maintain and can speed up installation.

Testing

All the Unit tests are passing

derlin commented 1 year ago

Hello @gdrosos, thank you for this contribution !

However, attr is now used in https://github.com/divio/divio-cli/blob/master/divio_cli/localdev/push.py#L8. This was introduced in https://github.com/divio/divio-cli/commit/0439de12a107b81bb84f4bf911f0f889b7d29a52#diff-9ff3a019c7d4f1a57949b6e6735b6c2db68f8369866aacf678cf88d8d3bed63cR8

I believe we can close this PR, but don't hesitate if you see something like that again!

gdrosos commented 1 year ago

Hello @derlin, thanks for the response! You are right, sorry for thr trouble!

divio / divio-cli