divnix / std

A DevOps framework for the SDLC with the power of Nix and Flakes. Good for keeping deadlines!
https://std.divnix.com
377 stars 41 forks source link

fix: broken `lib` follows #348

Closed LiGoldragon closed 10 months ago

LiGoldragon commented 10 months ago

I was unable to override the nixlib passed to inputs which used haumea's input.

whs-dot-hk commented 10 months ago

You can override in flake.nix with inputs.dmerge.inputs.nixlib.follows = "sth";

blaggacao commented 10 months ago

Ah just saw this. Yes, if I'd prefer if the direct second-level input override is workable, because this adds another (separate) input entry for std in downstream flake.lock files and std already suffers from excessive inputs, so if anything, I'd like to reduce them as much as we can (and keep them minimal).

whs-dot-hk commented 10 months ago

O, sorry I actually mean inputs.std.inputs.dmerge.inputs.nixlib.follows = "sth";

LiGoldragon commented 10 months ago

O, sorry I actually mean inputs.std.inputs.dmerge.inputs.nixlib.follows = "sth";

That doesn't work:

 error: input 'std/dmerge/nixlib' follows a non-existent input 'std/haumea/nixpkgs'

Even if std.inputs.haumea.inputs.nixpkgs.follows is set.

LiGoldragon commented 10 months ago

Aditionally, the whole of avoiding to call lib by its long-established name is absurd. Nixpkgs is not lib.

blaggacao commented 10 months ago

Nixpkgs is not lib.

I agree. There's semantic value to this PR, regardless if it could be worked around. Maybe that should prime over reduction of inputs.

https://github.com/divnix/hive/issues/22

blaggacao commented 10 months ago

adapted in https://github.com/divnix/std/pull/349

LiGoldragon commented 10 months ago

adapted in https://github.com/divnix/std/pull/349

You're awesome! 🙏