rvacaru
commented
4 years ago I see that many commits in this branch are also in branch toppick-update.
In general we should avoid having a branch on top of another branch unless they really depend on each other.
Usually for separate features / refactoring tasks we'd have two separate branches from master, so reviewers don't review the same code twice and the pull requests are smaller.
In case you want to have a branch based on another branch and open pull requests of those I would advice:
- when opening the pull request of the branch based on the other branch, select to view the file changes (diff) from the other branch and not from master, so reviewers can see only the changes actually made from the branch
- in both the pull requests describe and link the other branch that needs to be merged together
New service: a postgres database, with just one table, that records who (email) bought what (item) at what price. A consumer of a new topic is almost ready, to be tested when the branch with the producer within the service is going to be included in master.