divonlan / genozip

A modern compressor for genomic files (FASTQ, SAM/BAM/CRAM, VCF, FASTA, GFF/GTF/GVF, 23andMe...), up to 5x better than gzip and faster too
Other
159 stars 12 forks source link

"Make reference" error in the docs #22

Closed jimmybgammyknee closed 2 years ago

jimmybgammyknee commented 2 years ago

Just doing some testing on the make-reference option

FASTA-specific options (ignored for other file types):

--make-reference  Compresss a FASTA file to be used as a reference in --reference or --REFERENCE.
Example: genozip --make-reference hs37d5.fa.gz

Example: cat *.fa | genozip --input fasta --make-reference --output myref.ref.genozip

That example gives a seg fault because no input stream is specified. I think you just missed the - after --make-reference

Example: cat *.fa | genozip --input fasta --make-reference - --output myref.ref.genozip
divonlan commented 2 years ago

Thanks for the catch! I updated the documentation, and the seg fault will go away in the next release.

On Thu, Mar 17, 2022 at 10:29 AM Jimmy Breen @.***> wrote:

Just doing some testing on the make-reference option https://genozip.readthedocs.io/genozip.html#cmdoption-make-reference

FASTA-specific options (ignored for other file types):

--make-reference Compresss a FASTA file to be used as a reference in --reference or --REFERENCE. Example: genozip --make-reference hs37d5.fa.gz

Example: cat *.fa | genozip --input fasta --make-reference --output myref.ref.genozip

That example gives a seg fault because no input stream is specified. I think you just missed the - after --make-reference

Example: cat *.fa | genozip --input fasta --make-reference - --output myref.ref.genozip

— Reply to this email directly, view it on GitHub https://github.com/divonlan/genozip/issues/22, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANN4H5ZTAZESO7HIHGPMSFLVAJYWHANCNFSM5Q5LTATQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>