Rohin's Review

[rohinsood]

Video

Crossover Score	Runtime	Plan	Github	Analytics
.83	Link	Link	On individual tickets

Name	Team+Indi+Teacher	Runtime	Key Commit(s)	Analytics
Rohin S	.83+.85+X	Fibonacci & BubbleSort	Fibonacci Via Memo & Recursion Bubble Sort via Recursion	Backend Commits Frontend Commits Profile

Features

• Fibonacci Calculation
  • Determine fibonacci retracement levels
  • Requirements: Space & time efficient, abstracted
• Monthly Sorting
  • Ascending sort the different months according to their high average value

Fibonacci

Inheritance

public abstract class Fibo {
  public abstract int fibonacci(int n);
}

public class FibonacciViaRecursion extends Fibo {

  @Override
  public int fibonacci(int n) {
    if (n <= 1) {
      return n;
    } else {
      return fibonacci(n - 1) + fibonacci(n - 2);
    }
  }

  public static void main(String[] args) {
    Fibo fibo = new FibonacciViaMemoization();
    int n = 4;
    int result = fibo.fibonacci(n);
    System.out.println(result);
  }

}

• Fibonacci via Recursion reflection:
  • Extrememly inefficeint O(2^n)
  • Exponential growth

                     fibonacci(4)
                  /                  \
        fibonacci(3)              fibonacci(2)
      /             \            /             \
    fibonacci(2)   fibonacci(1)   fibonacci(1)   fibonacci(0)
    /           \
    fibonacci(1) fibonacci(0)

public class FibonacciViaMemoization extends Fibo {

    private static Map<Integer, Integer> memo = new HashMap<>();

    @Override
    public int fibonacci(int n) {
        if (n <= 1) {
            return n;
        }

        if (memo.containsKey(n)) {
            return memo.get(n);
        }

        int result = fibonacci(n - 1) + fibonacci(n - 2);

        memo.put(n, result);

        return result;
    }
    public static void main(String[] args) {
        Fibo fibo = new FibonacciViaMemoization();
        int n = 4;
        int result = fibo.fibonacci(n);
        System.out.println(result);
    }
}

• Fibonacci via Recursion Reflection:
  • Good attempt at reducing complexity, best case is O(n), worst case is still O(n!)

                     fibonacci(4)
                  /                  \
        fibonacci(3)              fibonacci(2)
      /             \            /             \
    [2]    [1]    fibonacci(1)   [1]    fibonacci(0)
    /            \
    [1]      [0]

• Since only 5 retracement levels are used, the run time is the same,

MonthlyStocks Sorting

Inheritance

package com.nighthawk.spring_portfolio.mvc.stocks.sorting;

import java.util.List;

import org.springframework.util.StopWatch;

import com.nighthawk.spring_portfolio.mvc.stocks.MonthlyStocks;

public class MonthlyStocksSorter {

    StopWatch sw = new StopWatch();
    int comparisons;

    public SortedData bubbleSort(List<MonthlyStocks> monthlyStocksList) {
        return null;
    }

    public SortedData selectionSort(List<MonthlyStocks> monthlyStocksList) {
        return null;
    }

    public int compareStrings(String str1, String str2) {
        this.comparisons++;
        try {
            double value1 = Double.parseDouble(str1);
            double value2 = Double.parseDouble(str2);
            return Double.compare(value1, value2);
        } catch (NumberFormatException e) {
            // Handle parsing errors or decide how to compare non-numeric strings
            return str1.compareTo(str2);
        }
    }
}

package com.nighthawk.spring_portfolio.mvc.stocks.sorting;

import java.util.List;

import com.nighthawk.spring_portfolio.mvc.stocks.MonthlyStocks;

public class Ascending extends MonthlyStocksSorter {

  public SortedData recursiveBubbleSort(List<MonthlyStocks> monthlyStocksList, int n) {
    boolean swapped = false;

    super.sw.start();
    for (int i = 1; i < n; i++) {
        if (super.compareStrings(monthlyStocksList.get(i - 1).getHigh(), monthlyStocksList.get(i).getHigh()) > 0) {
            // Swap elements
            MonthlyStocks temp = monthlyStocksList.get(i - 1);
            monthlyStocksList.set(i - 1, monthlyStocksList.get(i));
            monthlyStocksList.set(i, temp);
            swapped = true;
        }
    }
    super.sw.stop();

    if (!swapped || n == 1) {
        return new SortedData(super.comparisons, super.sw.getTotalTimeMillis(), monthlyStocksList);
    } else {
        return recursiveBubbleSort(monthlyStocksList, n - 1);
    }
}

}

• Recursive Bubble Sort Reflection:
  • Worst case, O(n^2)

Overall Reflection

• Wanted to experiment with unconventional technology and gain new experiences developing solutions to already solved problems
  • Did so via the implementation of recursion and memoization, both of which are topics I am unfamiliar with.

[PaarasPurohit]

Individual Review "My name" grading "Their name"

• [x] Individuals should show that they were key contributors and examples to the team. This includes their participation in ideas, and plans, creating individual issues, providing code commits to projects, crossover grading participation, being on task and positive example in the classroom.

Individuals Video, Issue(s), Commits(s)

• [x] Video, includes Web demo of key contribution to the project, 1 minute (0.9)
• [x] Issue(s) that show plans/progress to team objectives (0.8)
• [x] Highlights of key commit(s) in Issues, summarizes code contributions (0.8)

• [x] Review GitHub analytics for key commits each week during the project, shows consistent participation for 3 weeks (0.9)

  Per check.
  0.55 not attempted/no check 0.7 attempted, incomplete, but some runtime 0.8 mastery and runtime 0.9 above and beyond.

Something I liked was how communication with other team members ran smoothly. The frontend, backend, and connection ran smoothly and I liked how the collaboration was run to produce a project of good quality. Something that could've been improved on, in retrospect, would be more focus on algorithm analysis. I didn't see a lot of Big O Notation presented in the ticket or the project. Overall, the score averages 0.85 out of 0.9. Good job!