search

divppc / Physio-App

Physio Dashboard
http://physio.div.agency/program-builder-tools.html
0 stars 0 forks source link

Urgent task design changes #64

Closed sonit1810 closed 6 years ago

sonit1810 commented 6 years ago

Please check these design changes, this is urgent, thanks!

https://zpl.io/bz8YpP8 https://zpl.io/adxAnv5

divppc commented 6 years ago

you need also all of this links with new icons? http://joxi.ru/xAeJo0LSpqXGwr

divppc commented 6 years ago

on this page http://physio.div.agency/program-builder-tools.html

right sidebar also should be collapsible and positioned by absolute? now it fixed here, but in new design they overlaps content from right side, on this page it should be positioned by absolute value http://joxi.ru/EA49YvQswypVDr

divppc commented 6 years ago

or only on this page right side bar should overlaps the content from right side? and stay fixed here http://physio.div.agency/program-builder-tools.html

sonit1810 commented 6 years ago

Hi Ihor,

For this one : https://zpl.io/bz8YpP8 Yes i think this page contains new icon only, can you change to use that icons ?

For this one : https://zpl.io/adxAnv5 I don't know why put a panel in right side like that, that panel does not have any meaning on Insight page. Let me ask Justin

sonit1810 commented 6 years ago

I think he want right bar can collapse at this page http://physio.div.agency/program-builder-tools.html

And keep Insight page stayed, no add right bar to Insight page. Please do it ASAP Ihor

divppc commented 6 years ago

Please check this page http://physio.div.agency/active-programs.html

tell me please if something wrong or if something else must be changed. This page not uploaded yet, awaiting for your feedback.

sonit1810 commented 6 years ago

Sorry i don't know because i don't design page, and Justin just ask designer do it, and give file to me to ask you cut/update. It's very hard for me to understand it. So now i don't understand. So please keep Insight page as now, don't do any changes on it.

sonit1810 commented 6 years ago

Insight page = active-programs.html, don't do any change until i get confirm from Justin, because new design file look very silly if we add right bar , no meaning.

divppc commented 6 years ago

ok, i'll be waiting instructions from you

sonit1810 commented 6 years ago

Ok, please wait for Insight page

And do changes for Program Builder Page, add Collapse for Right Bar, with design like this one

image

divppc commented 6 years ago

sure about this? now on Program builder page right sidebar has usual static position, if i'll change it to position: absolute and collapse sidebar - page will looks like this http://joxi.ru/xAeJo0LSpqbY1r

everything in the center content will be wider

sonit1810 commented 6 years ago

Yes i think that's what Justin want, add collapse to right bar. Please do it.

On Fri, Sep 15, 2017 at 12:00 AM, divppc notifications@github.com wrote:

sure about this? now on Program builder page right sidebar has usual static position, if i'll change it to position: absolute and collapse sidebar - page will looks like this http://joxi.ru/xAeJo0LSpqbY1r

everything in the center content will be wider

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/divppc/Physio-App/issues/64#issuecomment-329545503, or mute the thread https://github.com/notifications/unsubscribe-auth/AHoaEdLawUn4IO_csdt0-Gy2zGgvXy69ks5siVuxgaJpZM4PXR0L .

sonit1810 commented 6 years ago

Also don't forget remain small line/icon on the right when right bar collapsed so we can expand it again.

Please do Part to buttons as Type section, and add collapse & expand option to Type & Part section, as i requested in another issue too.

Thanks!

On Fri, Sep 15, 2017 at 12:16 AM, Truong Sơn truongson1810@gmail.com wrote:

Yes i think that's what Justin want, add collapse to right bar. Please do it.

On Fri, Sep 15, 2017 at 12:00 AM, divppc notifications@github.com wrote:

sure about this? now on Program builder page right sidebar has usual static position, if i'll change it to position: absolute and collapse sidebar - page will looks like this http://joxi.ru/xAeJo0LSpqbY1r

everything in the center content will be wider

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/divppc/Physio-App/issues/64#issuecomment-329545503, or mute the thread https://github.com/notifications/unsubscribe-auth/AHoaEdLawUn4IO_csdt0-Gy2zGgvXy69ks5siVuxgaJpZM4PXR0L .

divppc commented 6 years ago

done, uploaded, awaiting for review