Team member page

[sonit1810]

Hi Ihor,

Please cut this team member page (new design)

https://zpl.io/2j5Nopb

Thanks!

[sonit1810]

Pleas notes left sidebar has new icons for pages too, please use that new icons.

Thanks!

[sonit1810]

[divppc]

missing icons http://joxi.ru/p27OY7WIoYg0V2

[sonit1810]

Hi IHor,

Designed reup file https://zpl.io/2j5Nopb

Thanks!

On Wed, Sep 20, 2017 at 1:28 AM, divppc notifications@github.com wrote:

missing icons http://joxi.ru/p27OY7WIoYg0V2

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/divppc/Physio-App/issues/69#issuecomment-330629469, or mute the thread https://github.com/notifications/unsubscribe-auth/AHoaEVK_Z8C3d6SHCfeRirFCF86GDMQGks5skAffgaJpZM4PYWuH .

[divppc]

Hi Sonit, please check the link, it doesn't work for me

[sonit1810]

Hi Ihor,

Justin said he can access it, can you retry ?

On Wed, Sep 20, 2017 at 8:28 PM, divppc notifications@github.com wrote:

Hi Sonit, please check the link, it doesn't work for me

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/divppc/Physio-App/issues/69#issuecomment-330851061, or mute the thread https://github.com/notifications/unsubscribe-auth/AHoaEbHP9PWihayF4RNM0K5NvJZE_M27ks5skRLggaJpZM4PYWuH .

[divppc]

now it works, thanks

[divppc]

Hi Sonit.

Please ask designer to provide pencil icon too, he missed it. Thanks

[divppc]

Sonit, i'm almost finished new team page, should i wait for missing pencil from designer or find something similar in the internet?

[sonit1810]

Hi Ihor,

Please find one icon similar to use.

Thanks.

On Sep 21, 2017, at 11:44 PM, divppc notifications@github.com wrote:

Sonit, i'm almost finished new team page, should i wait for missing pencil from designer or find something similar in the internet?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[sonit1810]

Hi Ihor,

Also new mockup uploaded at https://zpl.io/2j5Nopb

Meaning of icons

[divppc]

done http://physio.div.agency/team.html

[sonit1810]

so the file member-new.html is empty ?

[divppc]

here link

done http://physio.div.agency/team.html

member-new.html can be deleted

[sonit1810]

ok Ihor, I used that layout for other setting pages and it works fine.

Can you add profile icon for left side bar, from profile icon on dashboard ?

[divppc]

Hi Sonit, yes, ok

[sonit1810]

Hi Ihor,

ID for color of type of Role, does it affect to other effect ? I followed your format, then it works. But when i changed name of select list to different then it does not work.

[divppc]

please provide link for this page

[sonit1810]

Don't worry Ihor, i understand how it works now, thanks

[divppc]

Yes, it's take role from selected option)

[sonit1810]

Also, I saw you used label:after to make effect of radio button ROLE, but if one row has status active (value=1) then i don't know how to set it to green ? Can you add class so if value = 1 i can set it for radio or label so it can checked (green color)?

[sonit1810]

Sorry Ihor, my bad, i can set radio checked, and it display ok now. Thanks & sorry, i'm mad now.

[divppc]

It's a usual input[type="checkbox"] you can change status by attribute checked http://joxi.ru/v294YlLI3w6vxm

i hope this helps you

[divppc]

ok, no problem)

[sonit1810]

Hi Ihor,

It does not affect if it's checked, then i set it inactive, it does not remove checked attribute of checkbox , so data submit is wrong

[sonit1810]

[divppc]

Input type checkbox don't have inactive attribute, it can only be checked or remove attribute checked. And in HTML5 you don't need to write checked="checked", only one word checked is enough. Please see screen shot http://joxi.ru/v294YlLI3w6vxm

[sonit1810]

You can try : http://mpa.jsoft.com.au/application/setting/team-members

try change row "Lead Physio Test" (click Pencil icon to edit that row), change status to Inactive, and save it, and reload page, you will see it display active again.

And after you change to inactive, check html code, the radio still has checked="checked", that's why data submit active=1

[sonit1810]

yes, i now, can use checked or checked="checked" no matter, what i meant is when you click to radio to set it inactive (not checked), color of button changed to gray and it moved to left, look correct on UI, but in HTML , that radio still checked, that's caused data submit wrong when saving

[divppc]

it works fine for me http://joxi.ru/Q2KVZ75h4EjxKm

i change row, turn off activity, save changes, reload pages and everything saved

[sonit1810]

No Ihor, what you saw is in UI, actually data posted wrong, the radio does not changed checked to unchecked , compare UI by these steps

• first load
• change ui, see UI , and data posted
• reload, and see UI again, it's the same at first load, radio does not changed

I'm using Chrome in Windows Version 60.0.3112.113

Please see this video

https://www.youtube.com/watch?v=9E4zY-C9rJQ&feature=youtu.be

[sonit1810]

It works now Ihor, don't worry, it's a bug in coding, my god, i'm mad nowwww

[divppc]

yes, everything ok with input, you did something wrong when try to get input value here video https://drive.google.com/file/d/0B0_xf8lTXfWBTXE0RkRGNm9pR0U/view?usp=sharing

[divppc]

I used that layout for other setting pages and it works fine.

Can you add profile icon for left side bar, from profile icon on dashboard ?

done http://physio.div.agency/team.html

[sonit1810]

Hi Ihor,

I added hyperlink for columns, it has different color

And when i click to one column, i set class for it, and it changed position too

Can you check and fix it ? Columns position and color should keep as first load, when click to column.

[divppc]

Hi Sonit, fixed

[sonit1810]

Thanks!