divppc / Physio-App

Physio Dashboard
http://physio.div.agency/program-builder-tools.html
0 stars 0 forks source link

Need style add-exercise parameters look same with card page #79

Open sonit1810 opened 6 years ago

sonit1810 commented 6 years ago

Hi Ihor,

I cloned "program-setting" section from card page to add exercise page, and added some css to custom.css (this is my file), now it looks like below, too bad, we need

image

image

This is cloned css

image

It should look like this in card page image

Can you login to check and make css for me and send me back css you adjusted ?

Login to mpa.jsoft.com.au , triton@gmail.com/123456 Then go to setting page, my exercises , then add exercise, or use this direct link https://mpa.jsoft.com.au/application/setting/add-exercise

Please do this asap.

Thanks!

divppc commented 6 years ago

Hi Sonit.

Try to wrap block .program-settings into

...

sonit1810 commented 6 years ago

Hi Ihor,

Look not affected

image

Would you like FTP to mpa.soft.com.au, so you can modify custom.css and test online too ? It's easier for you.

divppc commented 6 years ago

it should be like this

<section class="card">
    <div class="program-settings">....</div>
</section>
sonit1810 commented 6 years ago

No Ihor, i can not use "card" section for it, because it's General page, i used chat layout, and you already style parts & types radio list in add-exercise section

image

So i cloned css for

section.add-exercise .program-settings

But it look still not good.

This is mixed layout it's not in design, so it's not in your file too ( http://physio.div.agency/add-exercise.html )

Or maybe you can add that sliders & input into http://physio.div.agency/add-exercise.html , then i will clone it to current dev page ?

Thanks!

sonit1810 commented 6 years ago

Also, can you fix this style too ? These radio sit too near , i don't know why, i cloned from type section :D. Or you can add that row into add-exercise.html page too, i will apply for dev site later then.

Thanks!

image

divppc commented 6 years ago

ok, now program settings styles are global

sonit1810 commented 6 years ago

Thanks Ihor, i don't mind it's global or not, just want it styled same in program card page and add exercise page, i will try. Can you add parameter section into add-exercise.html so i can see it as sample ?

Thanks!

On Mon, Oct 23, 2017 at 7:31 PM, divppc notifications@github.com wrote:

ok, now program settings styles are global

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/divppc/Physio-App/issues/79#issuecomment-338643469, or mute the thread https://github.com/notifications/unsubscribe-auth/AHoaEQclLF4JyDrxDIQQcT6ZwrqCi7Fbks5svIcdgaJpZM4QCkpd .

divppc commented 6 years ago

Provide ftp details, I’ll fix it directly

Okal Ihor http://div.agency

On Oct 23, 2017, at 3:46 PM, SonITvWorker notifications@github.com wrote:

Thanks Ihor, i don't mind it's global or not, just want it styled same in program card page and add exercise page, i will try. Can you add parameter section into add-exercise.html so i can see it as sample ?

Thanks!

On Mon, Oct 23, 2017 at 7:31 PM, divppc notifications@github.com wrote:

ok, now program settings styles are global

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/divppc/Physio-App/issues/79#issuecomment-338643469, or mute the thread https://github.com/notifications/unsubscribe-auth/AHoaEQclLF4JyDrxDIQQcT6ZwrqCi7Fbks5svIcdgaJpZM4QCkpd .

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

sonit1810 commented 6 years ago

Hi Ihor, you can fix css only. Site does not have whole page in one file. They are templates files with ids too. I will give you ftp credentials after dinner. Im eating.

Thanks!

Sent from my iPad

On Oct 23, 2017, at 8:32 PM, divppc notifications@github.com wrote:

Provide ftp details, I’ll fix it directly

Okal Ihor http://div.agency

On Oct 23, 2017, at 3:46 PM, SonITvWorker notifications@github.com wrote:

Thanks Ihor, i don't mind it's global or not, just want it styled same in program card page and add exercise page, i will try. Can you add parameter section into add-exercise.html so i can see it as sample ?

Thanks!

On Mon, Oct 23, 2017 at 7:31 PM, divppc notifications@github.com wrote:

ok, now program settings styles are global

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/divppc/Physio-App/issues/79#issuecomment-338643469, or mute the thread https://github.com/notifications/unsubscribe-auth/AHoaEQclLF4JyDrxDIQQcT6ZwrqCi7Fbks5svIcdgaJpZM4QCkpd .

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

sonit1810 commented 6 years ago

Hi Ihor,

After you make global css for program-setting, it makes sections which i added to add exercise page can not modified, i think it's from your css.

So, can you add program-setting section into add-exercise.html ? I will take that part to dev template file. This is fastest way, so please do it.

Thanks!

image

sonit1810 commented 6 years ago

Or you can FTP mpa.jsoft.com.au ihor@mpa.jsoft.com.au IHOR123!

Modify css in css/custom.css

Then test it in mpa.jsoft.com.au

Your css file is style.css. If you made any changes please update style.css in repo too, so next times i pull it down it does not override what you changed.

divppc commented 6 years ago

i checked this page. The structure is wrong, also you missed classes and identifiers. Off course not all styles will works. So keep the original structure, and then if somethings will be wrong - i'll fix it directly.

sonit1810 commented 6 years ago

Hi Ihor,

I changed id and added extra class since i need work with them by javascript. But i kept your class already, and i think you made style by class, so it does not affected. Actually it worked on program builder page already.

image

So, i think best way is please add that section into this page : http://physio.div.agency/add-exercise.html Then commit it, i will take it and apply to dev myself. Please use class for style only.

Also please add "This exercise is" row, with radio buttons, like "type" or "part"

image

Thanks!

sonit1810 commented 6 years ago

Hi Ihor,

Can you do changes as my last comment ?

Thanks!

divppc commented 6 years ago

Hello, yes, i'll check it later

On Thu, Oct 26, 2017 at 6:12 PM, SonITvWorker notifications@github.com wrote:

Hi Ihor,

Can you do changes as my last comment ?

Thanks!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/divppc/Physio-App/issues/79#issuecomment-339698673, or mute the thread https://github.com/notifications/unsubscribe-auth/AR1TBw_pOctjEHxHEHWhFKqJdozK0s-Kks5swKFYgaJpZM4QCkpd .

-- Okal Ihor | http://div.agency

divppc commented 6 years ago

Hi Sonit. Please check this page http://physio.div.agency/add-exercise.html

i'll upload it if everything correct, or change if something wrong

sonit1810 commented 6 years ago

Thanks Ihor, it looks good. let me use it.

On Fri, Oct 27, 2017 at 5:21 PM, divppc notifications@github.com wrote:

Hi Sonit. Please check this page http://physio.div.agency/add- exercise.html

i'll upload it if everything correct, or change if something wrong

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/divppc/Physio-App/issues/79#issuecomment-339933732, or mute the thread https://github.com/notifications/unsubscribe-auth/AHoaEdQ6QSfaPrwki-5e8HTdwmS1Qr2Rks5swa6YgaJpZM4QCkpd .

divppc commented 6 years ago

commited https://github.com/divppc/Physio-App

sonit1810 commented 6 years ago

Hi Ihor,

It seems you forgot commit changes ? add-exercise.html still not changed ?

image

divppc commented 6 years ago

Hi Sonit, No, everything uploaded

http://physio.div.agency/add-exercise.html http://joxi.ru/EA49YvQsw5bekr http://joxi.ru/DmBnYDlfwk0eom

sonit1810 commented 6 years ago

Hi Ihor,

I can not see new changes when pull latest code. Can you double check at your side by clone repo and check it?

Thanks!

On Oct 28, 2017, at 4:34 PM, divppc notifications@github.com wrote:

Hi Sonit, No, everything uploaded

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

divppc commented 6 years ago

uploaded again, try update

divppc commented 6 years ago

Hi Sonit, everything ok with last changes?