search

divriots / dockit-react

5 stars 5 forks source link

Fixing CoreLayout padding overflow #93

Closed m4dz closed 3 years ago

gqio commented 3 years ago

centered :)

Le 19 oct. 2021 à 17:56, m4dz @.***> a écrit :

 @m4dz commented on this pull request.

In mdx-layout-core/src/CoreLayout.scss:

overflow: auto;

  • width: 100%; Ok, now I've got it: the margin: 0 auto; width: 100% is here to center the content in the grid top element on large screens. Removing all just pad the content to the left (which IMHO is better in term of readability).

So question is: do we prefer content centered, or lefty?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

georges-gomes commented 3 years ago

I prefer center.

image

m4dz commented 3 years ago

Hmm, made more tries, and if we keep the margin: 0 auto, even without the width:100%, we encounter the overflow issue again in small screens.

Screenshot 2021-10-19 at 19 00 17 Screenshot 2021-10-19 at 19 00 26

I'll dig it later, but a quick fix is removing the margin auto, but it pushes the content to the left.

m4dz commented 3 years ago

Awesome, thanks @mveres 🤩 🙏 !