divriots / story-to-design

Keep your Figma libraries true-to-code in a single click.
https://story.to.design
26 stars 0 forks source link

New component issue report #160

Closed emmartin-design closed 3 months ago

emmartin-design commented 3 months ago

Instead of a white fill, the plugin is pulling in a placeholder image style which isn't used in Storybook whatsoever.


Bug report identity: Please do not edit

Task path: ecX1Ph13FF1JfcVM4CrE/oqpnnBWLSiIBI7Jqo7mH/1ferg4311vxgp8

gqio commented 3 months ago

Hello @emmartin-design

Thanks a lot for reporting the issue.

Could you please tell us which button is not working, maybe with the screenshot of what you expect vs what you see.

Actually in this report there is 512 buttons, maybe you could also report less variations to highlight better what is not working? Not mandatory now but for the next report.

Best.

emmartin-design commented 3 months ago

Sure! Any time there is a white fill, an image is applied to the background. This image doesn't have any connection to Storybook, and is used as a placeholder style in Figma only.

[image: image.png][image: image.png]

On Tue, Mar 19, 2024 at 8:03 AM Gregory Quinio @.***> wrote:

Hello @emmartin-design https://github.com/emmartin-design

Thanks a lot for reporting the issue.

Could you please tell us which button is not working, maybe with the screenshot of what you expect vs what you see.

Actually in this report there is 512 buttons, maybe you could also report less variations to highlight better what is not working? Not mandatory now but for the next report.

Best.

— Reply to this email directly, view it on GitHub https://github.com/divriots/story-to-design/issues/160#issuecomment-2007122272, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALZ5IHOBUD627XPIHVJIERLYZAZRLAVCNFSM6AAAAABE5PLASCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXGEZDEMRXGI . You are receiving this because you were mentioned.Message ID: @.***>

gqio commented 3 months ago

@emmartin-design apparently the copy paste of the images/screenshots didnt worked.

emmartin-design commented 3 months ago

Here's a link to a Figma file with the generated component from Storybook, and its Figma counterpart:

https://www.figma.com/file/mKfMOxg9UZfBJvgWkHd4ZN/TEMP-test?type=design&node-id=0%3A1&mode=design&t=qRG2LRQnPdYheV4q-1

My guess is that because our design library uses variables for our colors, the plugin used the only style with a white background... even though that style isn't correct. We don't house any customer-facing color values in our Figma styles. They're all in variables.

On Tue, Mar 19, 2024 at 4:01 PM Gregory Quinio @.***> wrote:

Sure!

Any time there is a white fill, an image is applied to the background. This

image doesn't have any connection to Storybook, and is used as a

placeholder style in Figma only.

[image: image.png][image: image.png]

On Tue, Mar 19, 2024 at 8:03 AM Gregory Quinio @.***>

wrote:

Hello @emmartin-design https://github.com/emmartin-design https://github.com/emmartin-design

Thanks a lot for reporting the issue.

Could you please tell us which button is not working, maybe with the

screenshot of what you expect vs what you see.

Actually in this report there is 512 buttons, maybe you could also report

less variations to highlight better what is not working? Not mandatory now

but for the next report.

Best.

Reply to this email directly, view it on GitHub

160 (comment)

https://github.com/divriots/story-to-design/issues/160#issuecomment-2007122272 ,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/ALZ5IHOBUD627XPIHVJIERLYZAZRLAVCNFSM6AAAAABE5PLASCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXGEZDEMRXGI

.

You are receiving this because you were mentioned.Message ID:

@.***>

Oops apparently the copy paste of the images didnt worked.

— Reply to this email directly, view it on GitHub https://github.com/divriots/story-to-design/issues/160#issuecomment-2008127755, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALZ5IHJ36QT4Z264RTFUEMTYZCRT3AVCNFSM6AAAAABE5PLASCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBYGEZDONZVGU . You are receiving this because you were mentioned.Message ID: @.***>

gqio commented 3 months ago

We don't house any customer-facing color values in our Figma styles.

Hello @emmartin-design

Just checked but not sure from where this is coming from 🤔

image

Do you have some library or value for this variable ?

emmartin-design commented 3 months ago

Yes—this is a style in our design library. It's a placeholder style for images in wireframes. It consists of two layers, a white layer and a png.

However, the white background we need is just a flat white. It's housed in our Figma Variables.

On Wed, Mar 20, 2024 at 9:40 AM Gregory Quinio @.***> wrote:

We don't house any customer-facing color values in our Figma styles.

Hello @emmartin-design https://github.com/emmartin-design

Just checked but not sure from where this is coming from 🤔

image.png (view on web) https://github.com/divriots/story-to-design/assets/1063530/7c9a4c66-8574-46cb-9872-f8dbb9940f28

Do you have some library or value for this variable ?

— Reply to this email directly, view it on GitHub https://github.com/divriots/story-to-design/issues/160#issuecomment-2009726852, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALZ5IHKNXAIWUFYRQNWEEXDYZGNURAVCNFSM6AAAAABE5PLASCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZG4ZDMOBVGI . You are receiving this because you were mentioned.Message ID: @.***>

muryoh commented 3 months ago

Hi @emmartin-design

We were able to identify and reproduce on our side, fix will be coming up soon

Thanks for letting us know!

muryoh commented 3 months ago

We just released a fix for it - the plugin needs to be updated (can be forced by refreshing the Figma tab)

You can choose the Reset Canvas option to force a redraw: image

Cheers, Remy