search

divriots / story-to-design

Keep your Figma libraries true-to-code in a single click.
https://story.to.design
26 stars 0 forks source link

Updating resetted property not working #169

Closed jens-meisner closed 1 month ago

jens-meisner commented 2 months ago

Updating imported component

By the way, if I change the borderWidth to a different number (and not undefined) the imported component is correctly updated.

Bug report identity: Please do not edit

Task path: o7ikEwELApDnbOUI8B6k/8cUxHdVkAQCctTUqstuS/1yykrg32d7r9n

muryoh commented 2 months ago

Hi @jens-meisner, sorry for the delayed feedback!

From what I can tell we do have logic to reset props I have been trying to reproduce specifically with the border-width, but it seems to work fine on my end Is this the workflow that is not working for you?

https://github.com/divriots/story-to-design/assets/1789748/6bb37093-6657-4aac-901a-635350b55775

Cheers, Remy

jens-meisner commented 2 months ago

Hi Remy,

Thanks for your detailed response.

In my case I set the border-width to a number, e.g. 25, which worked. Then I removed the border-width property (not set to 0 / zero) and synchronized, but the border-width was still 25.

Cheers, Jens

From: Remy @.> Sent: Thursday, 2 May 2024 17:52 To: divriots/story-to-design @.> Cc: Meisner, Jens @.>; Mention @.> Subject: Re: [divriots/story-to-design] Updating resetted property not working (Issue #169)

Hi @jens-meisnerhttps://github.com/jens-meisner, sorry for the delayed feedback!

From what I can tell we do have logic to reset props I have been trying to reproduce specifically with the border-width, but it seems to work fine on my end Is this the workflow that is not working for you?

https://github.com/divriots/story-to-design/assets/1789748/6bb37093-6657-4aac-901a-635350b55775

Cheers, Remy

— Reply to this email directly, view it on GitHubhttps://github.com/divriots/story-to-design/issues/169#issuecomment-2090865379, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BBBFBLZ323GRFCMMZVXGK4DZAJOKDAVCNFSM6AAAAABG2EXSGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQHA3DKMZXHE. You are receiving this because you were mentioned.Message ID: @.***>

muryoh commented 2 months ago

Are you able to reproduce with at will? No matter what I try I don't seem to be able to reproduce, be it with my demo storybook or yours

Would you mind sharing a video with me, possibly on Discord if you prefer? (https://story.to.design/chat, my login is remy.masson)

Best Remy

jens-meisner commented 2 months ago

2024-05-03 14-22-42.zip Here is the video, hope it helps. First change: (from 20) to “undefined” not working, Second change to a different number (to 2) is working.

Cheers, Jens

muryoh commented 2 months ago

Still no luck on my end

https://github.com/divriots/story-to-design/assets/1789748/3fcb17bd-876e-4477-a641-e4fa8fe2a861

Would you mind checking what is the reported border width on your button, in the devtools? image

Maybe it would help if I was able to reproduce with your storybook source code directly, although I understand this may be private

jens-meisner commented 1 month ago

Hi Remy,

Today the behaviour was flaky. Sometimes it was updated correctly (also for “undefined”) and sometimes not. The DevTools (on the storybook page) show a borderWidth of 1. I added another video, but I am not sure, if it helps. As said before...flaky 2024-05-06 08-51-49.zip

muryoh commented 1 month ago

Hi @jens-meisner,

Good news - I have a lead! Sorry it took me some time I believe there's a race condition specific to the Refresh Canvas action (specific to the local mode) where we "miss" the updated DOM

I'm looking into it 👍

jens-meisner commented 1 month ago

That sounds great! 👍

muryoh commented 1 month ago

Hi @jens-meisner , sorry about the late notice but we released a fix last week! (fix is mostly in the plugin, so if you reloaded your Figma tab since then you should benefit from the fix)

Hope it fixes your issue 👍 Don't hesitate to reopen if it doesn't