divriots / story-to-design

Keep your Figma libraries true-to-code in a single click.
https://story.to.design
29 stars 0 forks source link

The font weight is not the correct one #180

Closed dalexiev00 closed 5 months ago

dalexiev00 commented 6 months ago

Describe the problem

Hello, it's me again. We have problem with the font-weight of the text. Th and Td Cells are not the same as what we have. And the problem is not only for the table but other components as well. Could you check them as well, please? 🙏


Bug report identity: Please do not edit

Task path: ep257UoJEMTnEDJeFpEl/TQqm0csfOKONMqw0Wmmo/9uzt8k19v40ng

muryoh commented 5 months ago

Hi @dalexiev00, super sorry about the late feedback 🙏

I had a look at your issue today, here's what I saw:

Is this what you're seeing to, or are you seeing something different?

Best regards Remy

dalexiev00 commented 5 months ago

Hello 🙂 Thank you for your response! I just installed the font locally and checked on figma. The font is the right one but for some reason I see it more bolded instead of being thinner font-weight. I see on your screenshots that it's okay which is very strange 😅 image

muryoh commented 5 months ago

I imagine we did not install exactly the same font, or you have more available than I do In Figma, what other choices do you have other than Bulky?

dalexiev00 commented 5 months ago

Aah yes, I installed more fonts, but in the storybook is thinner, no? image

muryoh commented 5 months ago

Yes, I believe the problem is our mappings there In the browser weights only as numbers In Figma, you don't manipulate numbers, but style names

Which means we need to map them out - and I believe it's our first time seeing those style names, so we probably fallback to 400 instead of say 700 for Bulky

I cannot really test as I don't have the fonts, but I'm positive that would be the problem. I'll add the mappings for it and will let you know when to expect a release (best case would be today, worst case beginning of next week!) 👍

dalexiev00 commented 5 months ago

Okay, that's perfect, thank you 👌

muryoh commented 5 months ago

One thing though, could you confirm the weights with me if you have them available, or somehow send me the fonts (could be on Discord at https://story.to.design/chat, my pseudo there is remy.masson)

I imagine Slim => 100 or 200 or 300? Neutral => 400 Median => 500? Bulky => 700?

muryoh commented 5 months ago

nvm I think I found them - https://www.onlinewebfonts.com/fonts/polysans_qonto

dalexiev00 commented 5 months ago

Oh, that's perfect

muryoh commented 5 months ago

So, fyi:

  Slim: 300,
  Neutral: 400,
  Median: 600,
  Bulky: 700,
muryoh commented 5 months ago

Hi @dalexiev00 ! Just released a new version of the story.to.design plugin Just be sure to refresh your Figma tab if you had run the plugin before, then you should get the update on restart of the plugin

Finally, hitting Reset canvas should allow the new mapping to be pulled 🤞 image

Best regards, Remy

dalexiev00 commented 5 months ago

Hey, thank you for the update and work :) Only now I cannot use it on figma, it's stuck :/ image

muryoh commented 5 months ago

😱 I don't know what could be the problem, can you either come over on Discord to so we can further investigate?

I think we'll need the agent logs to analyze

dalexiev00 commented 5 months ago

Yes, of course :)