divriots / story-to-design

Keep your Figma libraries true-to-code in a single click.
https://story.to.design
28 stars 0 forks source link

Nested Component not detected #185

Closed tsryu closed 3 months ago

tsryu commented 3 months ago

Hello again :)

I'm trying to use nested components on Checkbox & CheckboxGroup.

But it does not show as a Checkbox instance inside CheckboxGroup.

Storybook Code Figma Component
스크린샷 2024-06-28 오후 7 21 46 스크린샷 2024-06-28 오후 7 16 20

Radio & RadioGroup have the same structure as Checkbox & CheckboxGroup. But Radio is recognized as instance.

Storybook Code Figma Component
스크린샷 2024-06-28 오후 7 22 25 스크린샷 2024-06-28 오후 7 15 36

As I checked the logs, there seems no problem with import process. Do you know why it's not recognized as a nested component?


Bug report identity: Please do not edit

Task path: 25Eqsg9Q3TpEpyGjd17z/lBxhIMbtM3yBbAUxTqc6/27ci5o1y6rjcj

muryoh commented 3 months ago

Hello again 😄

There might be a problem with the subcomponent matching Would you mind also reporting the checkbox component in the plugin? That way we can have a look at why the Checkbox Group does not use the Chechbox as a component 🙏

tsryu commented 3 months ago

Thanks for your help..!

This is Checkbox report code Task path: 25Eqsg9Q3TpEpyGjd17z/lBxhIMbtM3yBbAUxTqc6/1qvxkxo186fe7k

Let me show you Checkbox and Radio code too.

스크린샷 2024-07-01 오전 10 56 11

As you see the code above, these components are wrapped to recognize it as a boolean prop. (e.g.- showThumbnail, showSubText, showBadge) Please note :)

muryoh commented 3 months ago

Hi @tsryu , I'm happy to report we identified a bug in the subcomponent matching - we'll release a fix soon 👍 image

muryoh commented 3 months ago

We'll release the fix soon 🤗

muryoh commented 3 months ago

Just did, make sure to reload your Figma tab to benefit from the latest plugin release!

Best regards Remy

tsryu commented 3 months ago

Thanks for your help 🥇 Let me update the plugin