search

divviup / janus

Experimental implementation of the Distributed Aggregation Protocol (DAP) specification.
Mozilla Public License 2.0
53 stars 15 forks source link

Re-encryption of database contents when rotating datastore keys #1618

Open divergentdave opened 1 year ago

divergentdave commented 1 year ago

In the long term, we should be able to rotate the datastore encryption key, re-encrypt all data with a new key, and destroy the old key once it is no longer in use. Currently, we rely exclusively on trial decryption to determine which key was used to encrypt any field. It seems impractical to do so in maintenance tooling to either check if a key is still used by at-rest data or to perform the re-encryption. (Note that most, but not all, encrypted data will be either re-encrypted or deleted over several weeks during the normal course of operation) To more efficiently handle this, we may want to assign identifiers to our keys, and make a breaking change to the format of encrypted fields to include this identifier. Then, the decrypt() method could skip trial decryption, and maintenance tooling could quickly scan tables, only checking these identifiers. (in fact, we could even push this to the database with substring(column FROM 0 FOR length))

(See also https://github.com/divviup/divviup-api/pull/302#issuecomment-1638785056)

branlwyd commented 1 year ago

Note that most, but not all, encrypted data will be either re-encrypted or deleted over several weeks during the normal course of operation

Task-related data will not be naturally rotated, and task-related data is the majority (all?) of encrypted data. I think we'll need a tool for this.

To more efficiently handle this, we may want to assign identifiers to our keys

I would prefer not to introduce key identifiers, given that: the overwhelming majority of the time we will have at most ~2 living keys at once, we are the only entity handling these keys, and this decryption will (I believe) only be done once per task per aggregator process due to the task-level caching, each task has a relatively tiny amount of encrypted data attached to it, and decryption happens at the application level. Trial decryption is OK here.

divergentdave commented 1 year ago

Ah, I misremembered which fields we encrypt. The only encrypted fields are task_aggregator_auth_tokens.token, task_collector_auth_tokens.token, task_hpke_keys.private_key, and task_vdaf_verify_keys.vdaf_verify_keys. That is a much smaller volume than I was thinking.