divviup / janus

Experimental implementation of the Distributed Aggregation Protocol (DAP) specification.
Mozilla Public License 2.0
54 stars 15 forks source link

Fix leak of channel sender #3406

Closed divergentdave closed 2 months ago

divergentdave commented 2 months ago

This fixes a leak of a channel sender, by removing a forget() call. We shouldn't leak this sender because the dispatcher task is supposed to run until all senders are dropped. Furthermore, some of our tests amplify this leak by creating and tearing down many queues, which causes file descriptor exhaustion for me locally. Closes #3405.