divviup / janus

Experimental implementation of the Distributed Aggregation Protocol (DAP) specification.
Mozilla Public License 2.0
53 stars 15 forks source link

Fixup garbage-collection-check clause of put_report_aggregation. #3415

Open branlwyd opened 1 month ago

branlwyd commented 1 month ago

...and put_leader_report_aggregation. The condition here was reversed, only allowing a non-expired report aggregation row to be updated by the put operations. In practice, this wasn't a problem, as in application code put_report_aggregation was always paired with put_aggregation_job, and the condition on put_aggregation_job was correct.

branlwyd commented 1 month ago

(see also https://github.com/divviup/janus/issues/2810#issuecomment-2359485245)