divviup / libprio-rs

Implementation of Prio in Rust.
Mozilla Public License 2.0
103 stars 31 forks source link

IDPF/Poplar1: Revisit use of bitvec::prelude::Lsb0 order #508

Open divergentdave opened 1 year ago

divergentdave commented 1 year ago

Implementing Encode and Decode for Poplar1AggregationParam is suggesting that Lsb0 may have not been a good choice for bit ordering in various intermediate storage data types. We may want to revisit this in the future to simplify things.

divergentdave commented 1 month ago

This will be addressed in the spec by cfrg/draft-irtf-cfrg-vdaf#433. We should be able to use Msb0 without any reversing.