divviup / libprio-rs

Implementation of Prio in Rust.
Mozilla Public License 2.0
104 stars 31 forks source link

"Discrete Fourier transform" is better known as "Number theoretic transform" #632

Open cjpatton opened 1 year ago

cjpatton commented 1 year ago

Most crypto libraries use "NTT" instead of "FFT".

divergentdave commented 7 months ago

Real World Crypto has got me energized to make this change, but I think it ought to wait for the next time we bump the minor version. My two big backwards compatibility concerns are FlpError::Fft (there's no way to get around the possibility that consumers may be using this enum variant) and FieldElementFftFriendly (we could perhaps have two traits, with a blanket impl linking them, but that introduces concerns about ambiguous method resolution).