search

divyang4481 / bizhawk

Automatically exported from code.google.com/p/bizhawk
0 stars 0 forks source link

SG-1000 is not SMS #258

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Start Recording a Movie file with EmuHawk for a SG-1000 game.  I chose Bomb 
Jack (Japan).
2. Record some input and save it.
3. Playback the Movie.  The platform is marked as "SMS" instead of "SG-1000".  
The playback is fine.

What is the expected output? What do you see instead?
Since SMSHawk is handling both SMS and SG-1000 games, is this an issue?

What version of the product are you using? On what operating system?
1.8.1 r7746

Original issue reported on code.google.com by hegyak on 29 Aug 2014 at 3:19

GoogleCodeExporter commented 9 years ago 
I guess there's some disagreement about changing this, so here's a question:

If you have a movie with platform "SMS" marked in the movie file, what does 
that tell you?

It doesn't tell you that the movie is for an emulation of the Sega Master 
System, as we see here with this issue, nor does it tell that the game was 
designed for the Sega Master System.
It doesn't tell you what core will play the movie; we only have one SMSHawk 
right now, but if there was another one, it would still put SMS there as we've 
done with QuickNES.
It doesn't tell you the gamedb Game.System.

I'm all for keeping SystemID as it is if it does something useful, but looking 
through the code, I see inconsistent and incorrect logic all over the place, 
and don't see anywhere where it's communicating useful information that 
shouldn't be communicated some other way.

Original comment by goyu...@gmail.com on 30 Aug 2014 at 7:28

GoogleCodeExporter commented 9 years ago 
It's aesthetic. The main idea is to have the actual system listed.  The core is 
marked as SMS which is right.

Original comment by hegyak on 31 Aug 2014 at 6:35