divyang4481 / firebreath

Automatically exported from code.google.com/p/firebreath
0 stars 0 forks source link

.gitignore rule too strict #101

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. commit a firebreath project to a git repository
2. clone the repository
3. try to build it

What is the expected output? What do you see instead?
expected: the project building successfully
instead: src/3rdParty/boost/boost/preprocessor/list/for_each_i.hpp and 
src/3rdParty/boost/boost/preprocessor/seq/for_each_i.hpp are not found

What version of FireBreath are you using? On what operating system and
browsers?
version 1.3.0

Please provide any additional information below.
these files should not be excluded from the *_i.* rule
adding the following line below the *_i.* rule should fix this:
!for_each_i.hpp

Original issue reported on code.google.com by dries.st...@gmail.com on 7 Nov 2010 at 11:47

GoogleCodeExporter commented 8 years ago
I don't know what this is supposed to catch, but maybe this could be "!*_i.hpp"?

Original comment by georg.fritzsche on 7 Nov 2010 at 6:37

GoogleCodeExporter commented 8 years ago
I think the *_i.* exclusions are for the COM interface files generated by the 
MIDL compiler on windows, but those filenames never end with .hpp so !*_i.hpp 
would be sufficient.

Original comment by dries.st...@gmail.com on 7 Nov 2010 at 6:53

GoogleCodeExporter commented 8 years ago
Ah, right, it is for the MIDL files. 
@Richard, shouldn't the generated file always be in buildex/ anyway?

Original comment by georg.fritzsche on 7 Nov 2010 at 10:30

GoogleCodeExporter commented 8 years ago
Yes, they should be.  If someone wants to either change it or submit a patch 
this can be accepted easily since we don't use it in git at this time =]

Original comment by taxilian on 8 Nov 2010 at 4:47

GoogleCodeExporter commented 8 years ago
This issue was closed by revision 18af663c3e.

Original comment by taxilian on 9 Nov 2010 at 10:37