divyang4481 / firebreath

Automatically exported from code.google.com/p/firebreath
0 stars 0 forks source link

Missing onWindowDetach event closing IE #104

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Generate a basic plugin (named ie: DummyTest) 
2. Load FBControl.html in IE=> All works 
fine. And plugin recevies onWindowAttached event and onPluginReady 
event.
3. Closes IE clicking on application close button.

What is the expected output? What do you see instead?

At this point I expect that the browser will destroy the plugin and my plugin 
will receive the onWidnowsDetached event and at least the ~DummyTest() will be 
called, but it isn't. 

What version of FireBreath are you using? On what operating system and
browsers?

I'm using FB v1.3.0 on Windows 7 and IE v8.0.7600.16385

I haven't yet found a complete fix, only partially. To send 
onWindowDetached I make the next change at FBControl.h: 

    // This is called on shutdown 
    void shutdown() 
    { 
        pluginMain->ClearWindow();    // <- Added line 
        delete pluginWin; pluginWin = NULL; 
    } 

This forces to send onWindowDetached event to DummyTest, but we still 
have the problem of calls to destructors (~DummyTest() and 
~DummyTestAPI()) not called. Probably the missing call to 
~DummyTestAPI() is related to issue #103 
(http://code.google.com/p/firebreath/issues/detail?id=103&colspec=ID%20Type%20St
atus%20Priority%20Milestone%20Owner%20Summary%20Stars).

For more information you can review discussion on 
http://groups.google.com/group/firebreath-dev/browse_thread/thread/4015d4d572483
d38/b9852c16b1d007c0#b9852c16b1d007c0

Best regards.

Original issue reported on code.google.com by noant...@gmail.com on 8 Nov 2010 at 10:49

GoogleCodeExporter commented 8 years ago
That was exactly the right fix.  Thanks.

Fixed in 
http://code.google.com/p/firebreath/source/detail?r=9a834c191178a91f9a0206867464
090c75b35afe

Original comment by taxilian on 9 Nov 2010 at 5:34