fbgen.py should have options for having a "gui disabled" plugin

divyang4481 / firebreath

Automatically exported from code.google.com/p/firebreath

0 stars 0 forks source link

fbgen.py should have options for having a "gui disabled" plugin #146

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago

fbgen.py should have options for having a window less plugin

right now user have to manually remove some parts of the code / set flag for 
disabling the window having that option in fbgen.py would be good feature.

Original issue reported on code.google.com by mital.d....@gmail.com on 18 Feb 2011 at 7:10

GoogleCodeExporter commented 8 years ago

Original comment by taxilian on 18 Feb 2011 at 7:12

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

sent pull request: https://github.com/firebreath/FireBreath/pull/7

Original comment by mital.d....@gmail.com on 18 Feb 2011 at 7:19

GoogleCodeExporter commented 8 years ago

One thing that will need to be changed in the pull request is that this isn't 
actually a "windowless" plugin. that's something different. What you want is a 
"no-gui" plugin.

Original comment by taxilian on 23 Feb 2011 at 5:51

GoogleCodeExporter commented 8 years ago

Agree .. can u suggest any other name ?? "--with-gui" ??? is that ok ??

Original comment by mital.d....@gmail.com on 23 Feb 2011 at 5:56

GoogleCodeExporter commented 8 years ago

--disable-gui perhaps?

Original comment by taxilian on 23 Feb 2011 at 5:58

GoogleCodeExporter commented 8 years ago

okei.. i will try changing this ... I would get this done in around after 12 
hours... any other change you want me to include in this pull request ?

Original comment by mital.d....@gmail.com on 23 Feb 2011 at 6:07

GoogleCodeExporter commented 8 years ago

Original comment by taxilian on 4 Mar 2011 at 7:11

Changed title: fbgen.py should have options for having a "gui disabled" plugin

GoogleCodeExporter commented 8 years ago

I have merged all my commits into single commit.. 
removed older pull request.. added another pull request which is mital/master 
to firebreath/master.

Also completed the "set all of the FBMAC_USE_* to 0 if gui is disabled" task.

please review and merge the following pull request.

https://github.com/firebreath/FireBreath/pull/10

Original comment by mital.d....@gmail.com on 4 Mar 2011 at 10:57

GoogleCodeExporter commented 8 years ago

This has been pulled and is in 1.5.  Thanks!

Original comment by taxilian on 14 Mar 2011 at 6:09

Changed state: Verified