divyang4481 / firebreath

Automatically exported from code.google.com/p/firebreath
0 stars 0 forks source link

shutdown() is never called in ActiveX of IE. (i.e. WM_DESTROY is captured by replaced (wrong) winproc) #47

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. start IE
2. close IE
3.

What is the expected output? What do you see instead?

What version of FireBreath are you using? On what operating system and
browsers?

1.0.0(May 2010 Dev source)   XP, IE 6/7/8

Please provide any additional information below.

I see that you replaced the winproc, but the WM_DESTROY is captured by that
replaced winproc, which does not do anything.  The original WM_DESTROY is
not reached and therefore shutdown() is not called for the activeX in IE. 

Original issue reported on code.google.com by xizhi...@gmail.com on 26 May 2010 at 2:34

GoogleCodeExporter commented 8 years ago
This is fixed in the latest nightly download.  I recommend using that until I 
can
release 1.1

Original comment by taxilian on 26 May 2010 at 3:22

GoogleCodeExporter commented 8 years ago
hi, thanks for the reply. 
I compiled with the 1.1 nightly source on June 3 2010. i am afraid the problem 
is
still there. 

If you set a break point at 

PluginWindowWin::~PluginWindowWin()
{
    // Unsubclass the window so that everything is as it was before we got it
F9 here-->    SubclassWindow(m_hWnd, lpOldWinProc);

}

You will see that this is NOT called for IE(any version). It is called by 
Firefox.
The reason is in the main post.  

Original comment by xizhi...@gmail.com on 3 Jun 2010 at 5:13

GoogleCodeExporter commented 8 years ago
I'll take a look at it.  It probably will not be until next week.

Original comment by taxilian on 3 Jun 2010 at 5:38

GoogleCodeExporter commented 8 years ago
This one has fallen off my radar; sorry, I've been really swamped. Is the 
behavior still there, or has it been fixed?

Original comment by taxilian on 14 Jul 2010 at 4:27

GoogleCodeExporter commented 8 years ago
Thanks for spotting this; the subclassed winproc should have been calling the 
old winproc, but was not.  It should be fixed in the latest nightly that will 
go into 1.2.

Sorry for the delay on this.

Original comment by taxilian on 9 Sep 2010 at 1:58