search

divyang4481 / firebreath

Automatically exported from code.google.com/p/firebreath
0 stars 0 forks source link

Mac Safari crashes when exit using Release 1.2 #69

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Uncompress the attached firebreath_testplugin_mac_crash.tgz
     The attached project is generated using fbgen.py. The code is generated without any changes (well, except FBControl.htm, I added embed tag)
2. Build the FireBreath project and copy MyTestPlugin.plugin into 
~/Library/Internet Plug-Ins
3. Close Safari if already running
4. Open FBControl.htm file then Command-Q to quit.
5. Repeat step 4 until Safari crashes.

What is the expected output? What do you see instead?
A: Safari should exit without errors. But crash reporter reports the plug-in 
process crashed.

What version of FireBreath are you using? On what operating system and browsers?
A: Release 1.2 was used. My MacBook Pro is running 10.6.4 Mac OS X, Safari is 
Version 5.0.2 (6533.18.5) running in 64-bit mode.

Please provide any additional information below.
If I set the Safari to run on 32-bit mode only. So far I have not seen any 
crashes. Also the place where it crashes some time varies. The attached crash 
stack traces are two cases. There was one more also mentioned in discussion 
thread: 
http://groups.google.com/group/firebreath-dev/browse_thread/thread/b49ce07e257b9
197

Original issue reported on code.google.com by sundevil...@gmail.com on 20 Sep 2010 at 5:32

Attachments:

GoogleCodeExporter commented 8 years ago 
why did you add the <embed> tag?  Have you checked to see if it crashes without 
that tag?

there is no reason that you should need that tag that I am aware of.

Original comment by taxilian on 20 Sep 2010 at 2:34

GoogleCodeExporter commented 8 years ago 
for future reference, we should generally only need the projects/MyTestPlugin 
directory =]

Original comment by taxilian on 20 Sep 2010 at 2:35

GoogleCodeExporter commented 8 years ago

Original comment by amack...@gmail.com on 20 Sep 2010 at 3:18

GoogleCodeExporter commented 8 years ago 
Issue 26 has been merged into this issue.

Original comment by taxilian on 20 Sep 2010 at 3:49

GoogleCodeExporter commented 8 years ago 
Well, I guess I don't need to add embed tag. The reason I added was just to 
ensure the maximum compatibility. But the bug itself is not related to the 
embed tag.

Original comment by sundevil...@gmail.com on 20 Sep 2010 at 3:51

GoogleCodeExporter commented 8 years ago 
I am pretty sure anything that we support supports the object tag; I recommend 
you remove it.  I've had weird issues with those before.

However, you are correct that the issue is not related to that.  I think we 
have a fix in that will prevent the crash; the crash is due to a problem that 
we believe is on the web browser side, which makes it very hard to fix 
properly, but the long and short is that the object was getting released when 
we should have still had a retain on it.  I have added extra retains and 
checks; it could now produce a memory leak, but it should be very minor and 
much less critical than the crash.

We'll keep looking at this, but in the mean time please let us know if the fix 
(in nightly build 40) works for you.

Original comment by taxilian on 21 Sep 2010 at 3:15

GoogleCodeExporter commented 8 years ago 
Thanks for the fix. I will try it today and will let you know if it is ok.

Original comment by sundevil...@gmail.com on 21 Sep 2010 at 3:36

GoogleCodeExporter commented 8 years ago 
Since the issue seems to no longer be produceable, we'll mark it fixed with the 
hack that we put in.  The general feeling is that this is a browser bug.

Original comment by taxilian on 25 Sep 2010 at 1:54