10.4 Support

[GoogleCodeExporter]

Hi All,
For my application it's very important to support 10.4 and ppc.  It seems like 
firebreath should work fine for 10.4, but a few small modification's have to be 
made.

The first modifications are clearly in the users realm (and thus outside of the 
scope of this feature request):
   The user must edit prepmac.sh such that cmake is invoked with the arguments:
-DCMAKE_OSX_ARCHITECTURES="i386;ppc" 
-DCMAKE_OSX_SYSROOT="/Developer/SDKs/MacOSX10.4u.sdk"

This will result in a binary being built that is compatible with 10.4 and above 
ppc and i386.

Here's where the feature request comes in:  firebreath doesn't compile against 
the 10.4u sdk, although it's very close.  To modify firebreath so that this is 
no problem for users in the future is very simple:
1) PluginWindowMacCococaCA.h needs an "#ifdef FBMAC_USE_COREANIMATION" block to 
prevent CoreAnimation from being included.  CoreAnimation is obviously not 
supported if you intend on targeting 10.4.

2)KeyCodesCarbon.h needs an enum added that was only introduced in 10.5 and 
later.  This can be just copied and pasted from the 10.5 sdk.  I don't believe 
the key codes or API's changed -- the enum is just unavailable.

I've modified my local version for these changes, but I hate forking my copy 
and it would be nice if 10.4 were supported out of the box.

Thanks,
Rob

Original issue reported on code.google.com by physics...@gmail.com on 23 Sep 2010 at 4:06

[GoogleCodeExporter]

FYI -- the enum that needs to be added is from HIToolbox/Events.h:
/* keycodes for keys that are independent of keyboard layout*/
enum {
  kVK_Return                    = 0x24,
  kVK_Tab                       = 0x30,
  kVK_Space                     = 0x31,
  kVK_Delete                    = 0x33,
  kVK_Escape                    = 0x35,
  kVK_Command                   = 0x37,
  kVK_Shift                     = 0x38,
  kVK_CapsLock                  = 0x39,
  kVK_Option                    = 0x3A,
  kVK_Control                   = 0x3B,
  kVK_RightShift                = 0x3C,
  kVK_RightOption               = 0x3D,
  kVK_RightControl              = 0x3E,
  kVK_Function                  = 0x3F,
  kVK_F17                       = 0x40,
  kVK_VolumeUp                  = 0x48,
  kVK_VolumeDown                = 0x49,
  kVK_Mute                      = 0x4A,
  kVK_F18                       = 0x4F,
  kVK_F19                       = 0x50,
  kVK_F20                       = 0x5A,
  kVK_F5                        = 0x60,
  kVK_F6                        = 0x61,
  kVK_F7                        = 0x62,
  kVK_F3                        = 0x63,
  kVK_F8                        = 0x64,
  kVK_F9                        = 0x65,
  kVK_F11                       = 0x67,
  kVK_F13                       = 0x69,
  kVK_F16                       = 0x6A,
  kVK_F14                       = 0x6B,
  kVK_F10                       = 0x6D,
  kVK_F12                       = 0x6F,
  kVK_F15                       = 0x71,
  kVK_Help                      = 0x72,
  kVK_Home                      = 0x73,
  kVK_PageUp                    = 0x74,
  kVK_ForwardDelete             = 0x75,
  kVK_F4                        = 0x76,
  kVK_End                       = 0x77,
  kVK_F2                        = 0x78,
  kVK_PageDown                  = 0x79,
  kVK_F1                        = 0x7A,
  kVK_LeftArrow                 = 0x7B,
  kVK_RightArrow                = 0x7C,
  kVK_DownArrow                 = 0x7D,
  kVK_UpArrow                   = 0x7E
};

Original comment by physics...@gmail.com on 23 Sep 2010 at 5:43

[GoogleCodeExporter]

If you will put your changes in a clone and tell us where to find them, we will 
be glad to look at it.

Original comment by taxilian on 23 Sep 2010 at 5:49

• Changed state: Accepted

[GoogleCodeExporter]

Looks good! I'd love to merge your local changes if you could throw them into a 
clone, as Richard said.

Original comment by amack...@gmail.com on 23 Sep 2010 at 2:13

[GoogleCodeExporter]

Note that you don't need to edit prepmac.sh as you can pass additional 
parameters to it: http://code.google.com/p/firebreath/wiki/PrepScripts

Original comment by georg.fritzsche on 23 Sep 2010 at 2:53

[GoogleCodeExporter]

for instructions on creating a clone: 
http://groups.google.com/group/firebreath-dev/browse_thread/thread/adfbe6fc6b3d9
aa7?pli=1

Original comment by taxilian on 23 Sep 2010 at 3:03

[GoogleCodeExporter]

Original comment by amack...@gmail.com on 27 Sep 2010 at 2:39

[GoogleCodeExporter]

rob; any status on this?  I see that you've created a clone, but not pushed any 
changes.

Not trying to rush you, just would love to be able to put this feature in 1.3, 
which is scheduled to release Oct 7 (a week from tomorrow).  If you could let 
us know where you're at that would be awesome.  if you need help with 
mercurial, let us know.

Original comment by taxilian on 29 Sep 2010 at 3:55

[GoogleCodeExporter]

To clarify, if doing a clone is too much trouble, you could submit us a patch / 
diff.  We would prefer the clone, since it's a lot easier for us to track where 
things come from, but we'll take what we can get =]

Original comment by rich...@firebreath.org on 1 Oct 2010 at 3:36

[GoogleCodeExporter]

Original comment by taxilian on 19 Oct 2010 at 9:03

• Added labels: Milestone-Release1.4

[GoogleCodeExporter]

This is in 1.4

Original comment by taxilian on 14 Mar 2011 at 5:57

• Changed state: Fixed