1.2.2.not building with Visual Studio 2005 (WinXP)

[GoogleCodeExporter]

What steps will reproduce the problem?

1. Attempting to build (either my project or examples) fails with the an error 
with VS2005 (on a WinXP system).

To confirm:

2. Attempting to build the same project that fails under VS2005 (on WinXP) 
works on a system with VS2008 (on WinVista).

3. Attempting to build projects and example on the same VS2005 (WinXP) system 
using version 1.2.0 works, so it seems to be a new issue.

What is the expected output? What do you see instead?

Would expect it to build with vanilla VS2005, as it did with previous versions, 
or should probably check and or state somewhere that WiX 3.0 or newer needs to 
be installed.

(It's failing because it's now looking for C:\Program Files\Windows Installer 
XML\bin\heat.exe which is an exe that I think only started shipping in WiX 3.0)

VS2005 Output:
------ Build started: Project: BasicMediaPlayer_WiXInstall, Configuration: 
Release Win32 ------
Compiling 
C:/TalkTalkDigitalHomePlugin/src/digital-home-firebreath-1.2.2/buildex/bin/Basic
MediaPlayer/Release/npBasicMediaPlayer.dll -> npBasicMediaPlayer.wxs
'"C:\Program Files\Windows Installer XML\bin\heat.exe"' is not recognized as an 
internal or external command,
operable program or batch file.
Project : error PRJ0019: A tool returned an error code from "Compiling 
C:/TalkTalkDigitalHomePlugin/src/digital-home-firebreath-1.2.2/buildex/bin/Basic
MediaPlayer/Release/npBasicMediaPlayer.dll -> npBasicMediaPlayer.wxs"
Build log was saved at 
"file://c:\TalkTalkDigitalHomePlugin\src\digital-home-firebreath-1.2.2\buildex\p
rojects\BasicMediaPlayer\BasicMediaPlayer_WiXInstall.dir\Release\BuildLog.htm"

What version of FireBreath are you using? On what operating system and browsers?

1.2.2 - VS2005/WinXP - Fails
1.2.2 - VS2008/WinVista - Works
1.2.0 - VS2005/WinXP - Works

Please provide any additional information below.

It seem WiX 3.0 is not required with version 1.2.2 but it's not explicitly 
checked for or mentioned (as far as I can see). This is not actually a problem 
for me, but thought I should mention it.

Original issue reported on code.google.com by iaincoll...@gmail.com on 7 Oct 2010 at 11:59

[GoogleCodeExporter]

The last paragraph should of course read "It seems WiX 3.0 is now required with 
version 1.2.2" sorry.

Original comment by iaincoll...@gmail.com on 7 Oct 2010 at 12:05

[GoogleCodeExporter]

Yeah, we should definitely mention that 3.0 or later is required.  However, if 
you have ever gotten this to work in Visual Studio 2005, that's more than we 
have seen.

I have only been able to get the WiX installer to work on 2005 and later.  This 
should really also be documented =]

There have not been any changes between 1.2.0 and 1.2.2 that would affect the 
installer in any way I can imagine; are you sure of your test results?

Original comment by taxilian on 7 Oct 2010 at 1:30

[GoogleCodeExporter]

For what it's worth, I can confirm it is indeed happily building workable 
plugins with 1.2.0 on VS2005/WINXP. I have v1.2.0 and v1.2.2 side by side on 
the same system, but 1.2.2 always fails with the above error on that system 
(not that it actually causes any problem for me as I say, as it's just fine on 
my VS2008/Vista system). I originally found this yesterday but checked both 
again today to check I wasn't high on coffee.

At first I was only using a VMware image with VS2005 as with some of the work 
I've done on other projects (specifically in odd cases related to installers - 
and I have to do one for this project so fired it up) because I've had to do 
this to ensure libraries that are not on a fairly vanilla XP system end up 
being depended on (that's the only reason why I keep it around)  - but this 
hasn't been an issue with FB of course.

Confusingly I see, at first glance at least, that you seem to be right about it 
not changing too, in that the only reference to heat.exe in FB is in 
"./cmake/wix.cmake" in both 1.2.0 and 1.2.2. ... so not sure what's going on 
there either (have mentally filed it under "cmake magic").

Original comment by iaincoll...@gmail.com on 7 Oct 2010 at 5:01

[GoogleCodeExporter]

does it actually work?  heat.exe has been required since the WiX installer was 
first added to the system; if it's not there, the installer won't work, whether 
it appears to generate the MSI or not.

Once you install WiX 3.0 or later and you have heat, my experience is that it 
still doesn't work on vs2005 because heat doesn't work properly on firebreath 
plugins generated with that version.  This is unfortunate, but from my research 
seems to be unavoidable and has to do with a missing feature in ATL 7

Original comment by taxilian on 7 Oct 2010 at 5:30

[GoogleCodeExporter]

Sorry for the delay, I was out of the office after I got your message.

No you are quite right there is something else going on here, on a fresh 
install of 1.2.0 the same issue is happening in both. Thanks for the 
explanations and sorry for any confusion and wasting your time.

Original comment by iaincoll...@gmail.com on 8 Oct 2010 at 10:46

[GoogleCodeExporter]

no worries; I would rather have you report it, figure out there is something 
going on, and mark it invalid than to find an issue and not let us know.
If nothing else, this tells us we need to try to get the 2005 thing and the 
3.0+ bit documented =]

Original comment by taxilian on 8 Oct 2010 at 1:53

• Changed state: Invalid