divyang4481 / lz4

Automatically exported from code.google.com/p/lz4
0 stars 0 forks source link

Compile error with VS2005 #24

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
STEPS:
1. Create a Win32 console project
2. Add LZ4 source files to the project
3. Start build

EXPECTED RESULT:
Successfull build

ACTUAL RESULT:
Build failed with error:
lz4hc.obj : error LNK2019: unresolved external symbol __BitScanForward 
referenced in function _LZ4_NbCommonBytes

Original issue reported on code.google.com by specialforest on 29 Jun 2012 at 2:32

GoogleCodeExporter commented 9 years ago
I suggest folowing patch

Original comment by specialforest on 29 Jun 2012 at 2:35

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the hint. I'll look into it.

Original comment by yann.col...@gmail.com on 1 Jul 2012 at 7:14

GoogleCodeExporter commented 9 years ago
OK, that's a long overdue one.
After quite some time, i could get a working station with VS2005 (not that 
simple, since VS2005 is no longer compatible with newer Windows versions).
I could correct all warnings and errors, for both the debug and release 
compilations and linking.
You'll find in copy a candidate version of LZ4 with the proposed corrections.
I've checked that it did not produce any side effect with VS2008 and VS2010.
I will spend some time now with GCC & Linux validations.

Could you please tell me if it works for you ?

Regards

Original comment by yann.col...@gmail.com on 10 Aug 2012 at 1:47

Attachments:

GoogleCodeExporter commented 9 years ago
I've check it. Great work!

Original comment by specialforest on 11 Aug 2012 at 10:30

GoogleCodeExporter commented 9 years ago
Thanks for testing. Correction is published into r75.

Original comment by yann.col...@gmail.com on 13 Aug 2012 at 7:33