search

divyang4481 / obfuscar

Automatically exported from code.google.com/p/obfuscar
0 stars 0 forks source link

[Patch] Parameters of private methods do not get renamed if the parent class is skipped #34

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I'm using the skip settings:
<SkipType name="*" />
<SkipMethod type="*" attrib="protected" name="*" />

As expected, private methods inside the class are renamed. However, their
parameters are not.
I would expect method parameters to get renamed whenever the method itself
gets renamed.

The problem is that Obfuscator.RenameParams() only checks 'ShouldSkip' of
the parent type. Instead, it should check the individual methods.
Attached patch #1 fixes this problem.

Additionally: why rename parameters when you can simply remove their name?
Patch #2 implements this improvement.

Original issue reported on code.google.com by daniel.g...@gmail.com on 3 Apr 2010 at 3:58

Attachments:

GoogleCodeExporter commented 9 years ago 
Should be marked as Closed. I can see some requested changes are made already 
in the code base.

Original comment by lextu...@gmail.com on 28 Apr 2013 at 7:38