divyanshudhruv / Minifolio

⚡ A minimal portfolio template for Developers | 2024
https://divyanshudhruv.github.io/Minifolio/
MIT License
54 stars 75 forks source link

Adding a background color to the nav bar #121

Closed Divii2205 closed 6 days ago

Divii2205 commented 1 week ago

🔥 Enhancement

🫤 Description

Adding a background color to the nav bar

📍 Use Case

A background color helps the nav bar stand out from the rest of the content on the page. This makes it easier for users to locate navigation elements quickly. It enhances readability.

🤔 To-Do

Adding a background color matching the theme of the website.

🌱 Contribute

I want to contribute to this issue @divyanshudhruv

divyanshudhruv commented 1 week ago

@Divii2205 can you share the screenshot of how it looks after adding background color? Thank you

Divii2205 commented 1 week ago

@Divii2205 can you share the screenshot of how it looks after adding background color? Thank you

Nav Bg Color

@divyanshudhruv kindly let me know if any changes are required

NechamaSopher commented 6 days ago

@Divii2205 Hi, I will love to do this, Can you please assign it to me?

divyanshudhruv commented 6 days ago

@Divii2205 you can open pull request in development branch after forking the main repo :)

NechamaSopher commented 6 days ago

Sorry @Divii2205 I didn't realize you wanted to do it. I was thinking of doing something like this (it is ready for pr if you want..):
image

divyanshudhruv commented 6 days ago

Sorry @Divii2205 I didn't realize you wanted to do it. I was thinking of doing something like this (it is ready for pr if you want..): image

@NechamaSopher you can open PR into development branch

Divii2205 commented 6 days ago

@Divii2205 you can open pull request in development branch after forking the main repo :)

I have opened a pull request. Please review it. Thank you @divyanshudhruv