Open Abhinab04 opened 3 days ago
@Abhinab04 please refer to #116
If you are able to create such type of buttons in navbar below the text in one horizontal line instead of creating the buttons to the right side of the footer text, I can assign it to you too.
You can share the screenshot of both cases-
sure, i can create that ,its more like contact us page @divyanshudhruv
@Abhinab04 I mean, can you create those 3-4 buttons just like the buttons shown in the screen shot inside the footer?
Okay, I am assigning you and please share the screen shot before opening the pull request. Good luck 👍
/assign
light theme: dark theme: is it looking good @divyanshudhruv
@Abhinab04 can you re-fork the repository with dev-main
as the branch because we will be merging it to that branch. You can pull the dev-main
branch and then add the required files for the social section. And don't worry if the navbar is not as same as your navbar, because the navbar is merged in a different branch. 👍
Review: The icons are looking too big, try to make them small and add spacing or margin above the icons so that the text and icons do not overlap. It will look clean then. Also, if possible, you can add a square box with some border-radius and border and then the icon inside it just like this -
suggested improvements: @divyanshudhruv
Yeah, that looks fine. @Abhinab04 You can open the pull request, I'll merge it in 2-3 days.
https://github.com/divyanshudhruv/Minifolio/pull/172 @divyanshudhruv ,i opened the pr kindly review it,thankyou
wanted to add social media section at footer for enhancement of website