feat: Add dark mode #2

[rahulpeacock]

Completed the feature Dark mode, issue - #2

[divyanshudhruv]

@Rahul-Palamarthi can you share a pic ?

[rahulpeacock]

@divyanshudhruv yes I will share the pic

[divyanshudhruv]

Ok please

[rahulpeacock]

@Rahul-Palamarthi can you share a pic ?

@divyanshudhruv here is the vid of the dark-mode

https://github.com/divyanshudhruv/Minifolio/assets/87606332/81d5bb30-d856-4a90-a955-e2a7502707da

[divyanshudhruv]

Cool

[divyanshudhruv]

Will merge after 6 oct

[divyanshudhruv]

Is the button responsive?

[rahulpeacock]

Is the button responsive?

The size of the button remains same (fine for mobile view also)

[divyanshudhruv]

Idk why but the terminal typing text is not visible in dark mode

[rahulpeacock]

I can fix it

[divyanshudhruv]

If you deploy your forked repo, it would be very easy for me to view changes. So please deploy the changed branch

[rahulpeacock]

Idk why but the terminal typing text is not visible in dark mode

I have fixed it and also made a PR

https://github.com/divyanshudhruv/Minifolio/assets/87606332/86bc50de-fd9c-4325-bf1a-405b14825ed8

[rahulpeacock]

If you deploy your forked repo, it would be very easy for me to view changes. So please deploy the changed branch

@divyanshudhruv should I deploy to gh-pages ?

[divyanshudhruv]

Yes yes, then share me the link, I will see then merge

[divyanshudhruv]

I think you should remove Your Name from the header.

[rahulpeacock]

I think you should remove Your Name from the header.

i mean there should be a placeholder so that the header styles will work properly (since using flex inside the header so that the dark-mode button will be at the end of the header)

[rahulpeacock]

Yes yes, then share me the link, I will see then merge

yes I will share the link

[divyanshudhruv]

Yes yes, then share me the link, I will see then merge

yes I will share the link

Ok, fast

[rahulpeacock]

Yes yes, then share me the link, I will see then merge

yes I will share the link

Ok, fast

@divyanshudhruv, Here is the link to the gh-pages from my forked repo

[divyanshudhruv]

Hello, please resolve some conflicts in the files

[rahulpeacock]

Hello, please resolve some conflicts in the files

Yes, I have solved the merge conflicts 🚀

[divyanshudhruv]

Can you remove the border from the button and set the button background as #f0f0f0 ? And also increase the size some.

[rahulpeacock]

Yes

[divyanshudhruv]

Ok please do

[rahulpeacock]

Ok please do

@divyanshudhruv, I have update the code and made a PR, You can see the changes in the gh-pages of my forked repo

[divyanshudhruv]

Ok, can I do some minor fixes in the code ? Then I will merge it

[rahulpeacock]

Ok, can I do some minor fixes in the code ? Then I will merge it

@divyanshudhruv I will be working on it 🍁

[rahulpeacock]

Ok, can I do some minor fixes in the code ? Then I will merge it

@divyanshudhruv I have completed the merge conflicts 🚀

[divyanshudhruv]

Ok so see the current portfolio and there is a back to top button. Just make the dark button as same like that. I mean the width,height the background color, the font color. And the hover style you can do on your own.

[rahulpeacock]

Ok so see the current portfolio and there is a back to top button. Just make the dark button as same like that. I mean the width,height the background color, the font color. And the hover style you can do on your own.

sure

[divyanshudhruv]

@Rahul-Palamarthi please resolve the conflicts

[rahulpeacock]

@divyanshudhruv sure

[divyanshudhruv]

Added the hacktoberfest-accepted label, will merge soon