Closed Sujal-2820 closed 11 months ago
Cool, will review it
Can you send a picture of the button on the mobile screen ? I do not have the device to look into the code at this time.
Sure @divyanshudhruv. Here are some snippets of the UI for Different dimensions of Smartphones:
For iPhone 12 Pro:
For Samsung Galaxy S8
For Google Pixel
Nice, but you can increase the top margin of the button to some extent. Also you may try to adjust the button to right of the text and share a pic. Then we can select which one to keep,the bottom one or the right one.
Ok 👍 I'll make the necessary changes and get back to you..
Here are the Updated versions:
1. Increased Top Margin of Button
2. Button adjusted to the right of the Text with centrally aligned Words inside Button
Can you decrease the padding of button so that the text- click me ,appear on the same line ? Then send a pic here. Good work
Thanks for the appreciation 🙂 Please review this..
NOTE: As soon as increase the space between the text and the button by even a small px, the button moves to the next line and whole appearance becomes dull
Oo, so what do you think, which one is better? Down button or right button ?
In my opinion the Down Button would be more desirable and soothing to have a look at. This is usually seen in most websites in smartphone view.
Here are the Updated versions:
1. Increased Top Margin of Button
You mean this one ??
Yes sir!
Ok can you publish you forked repo to gh pages? So that I can see the result ? I currently don't have the device to look into the code
Ok 👍. I'll notify you once the page is published
Ok also send me the link to gh page
Please review it once link to the page: https://sujal-2820.github.io/Minifolio/
Hello, I think you should do something to media query as the width of this tablet is very much but still instead of the button coming to right it is coming down. The down button should only be applicable to mobiles with less width not tablets with more width. Please see to it
Thanks for the suggestion 💯 I looked upon the issue and solved it accordingly.
Please review it and inform me about any changes needed: https://sujal-2820.github.io/Minifolio/
Cool all good. Good job , @Sujal-2820
Btw who is main collaborator ? @Sujal-2820 or @Sujal-12345
Actually @Sujal-2820 is the main account of mine. I have actually connected my github desktop to @Sujal-12345.
But the contribution counts from @Sujal-2820 only 😅
I am glad you liked it. Thanks!
Will merge it soon
Sure 👍 Thank you so much!!
Congrats @Sujal-2820
Wooh!!🚀 Thanks @divyanshudhruv for your support
Title: Move "Click Me" Button to New Line on Mobile Devices
Overview: This pull request addresses a layout issue on mobile devices where the "Click Me" button was not displaying correctly. The button has been adjusted to move to the next line, ensuring a better user experience on smaller screens.
Changes:
Approach: I added a media query to the CSS that targets screens with a maximum width of 375 pixels. Within this media query, I adjusted the styles for the "btn-about" button to ensure it displays as a block-level element, causing it to move to the next line on smaller screens while keeping the text in its original position.
Testing Instructions:
Checklist for Reviewers: