divyanshudhruv / Minifolio

⚡ A minimal portfolio template for Developers | 2024
https://divyanshudhruv.github.io/Minifolio/
MIT License
36 stars 40 forks source link

Made button appear at new Line in Smartphone View #48

Closed Sujal-2820 closed 11 months ago

Sujal-2820 commented 11 months ago

Title: Move "Click Me" Button to New Line on Mobile Devices

Overview: This pull request addresses a layout issue on mobile devices where the "Click Me" button was not displaying correctly. The button has been adjusted to move to the next line, ensuring a better user experience on smaller screens.

Changes:

Approach: I added a media query to the CSS that targets screens with a maximum width of 375 pixels. Within this media query, I adjusted the styles for the "btn-about" button to ensure it displays as a block-level element, causing it to move to the next line on smaller screens while keeping the text in its original position.

Testing Instructions:

  1. Open the application on a mobile device or in a responsive mode with a screen width of 375 pixels or less.
  2. Navigate to the section where the "Click Me" button is located.
  3. Verify that the "Click Me" button now appears on a new line while the text remains in its original position.

Checklist for Reviewers:

divyanshudhruv commented 11 months ago

Cool, will review it

divyanshudhruv commented 11 months ago

Can you send a picture of the button on the mobile screen ? I do not have the device to look into the code at this time.

Sujal-2820 commented 11 months ago

Sure @divyanshudhruv. Here are some snippets of the UI for Different dimensions of Smartphones:

For iPhone 12 Pro: image

For Samsung Galaxy S8 image

For Google Pixel image

divyanshudhruv commented 11 months ago

Nice, but you can increase the top margin of the button to some extent. Also you may try to adjust the button to right of the text and share a pic. Then we can select which one to keep,the bottom one or the right one.

Sujal-2820 commented 11 months ago

Ok 👍 I'll make the necessary changes and get back to you..

Sujal-2820 commented 11 months ago

Here are the Updated versions:

1. Increased Top Margin of Button space_Increase

 

2. Button adjusted to the right of the Text with centrally aligned Words inside Button image

divyanshudhruv commented 11 months ago

Can you decrease the padding of button so that the text- click me ,appear on the same line ? Then send a pic here. Good work

Sujal-2820 commented 11 months ago

Thanks for the appreciation 🙂 Please review this..

image



NOTE: As soon as increase the space between the text and the button by even a small px, the button moves to the next line and whole appearance becomes dull

divyanshudhruv commented 11 months ago

Oo, so what do you think, which one is better? Down button or right button ?

Sujal-2820 commented 11 months ago

In my opinion the Down Button would be more desirable and soothing to have a look at. This is usually seen in most websites in smartphone view.

divyanshudhruv commented 11 months ago

Here are the Updated versions:

1. Increased Top Margin of Button space_Increase

 

You mean this one ??

Sujal-2820 commented 11 months ago

Yes sir!

divyanshudhruv commented 11 months ago

Ok can you publish you forked repo to gh pages? So that I can see the result ? I currently don't have the device to look into the code

Sujal-2820 commented 11 months ago

Ok 👍. I'll notify you once the page is published

divyanshudhruv commented 11 months ago

Ok also send me the link to gh page

Sujal-2820 commented 11 months ago

Please review it once link to the page: https://sujal-2820.github.io/Minifolio/

divyanshudhruv commented 11 months ago

Screenshot_20231002_154108_Chrome

Hello, I think you should do something to media query as the width of this tablet is very much but still instead of the button coming to right it is coming down. The down button should only be applicable to mobiles with less width not tablets with more width. Please see to it

Sujal-2820 commented 11 months ago

Thanks for the suggestion 💯 I looked upon the issue and solved it accordingly.

Please review it and inform me about any changes needed: https://sujal-2820.github.io/Minifolio/

divyanshudhruv commented 11 months ago

Cool all good. Good job , @Sujal-2820

divyanshudhruv commented 11 months ago

Btw who is main collaborator ? @Sujal-2820 or @Sujal-12345

Sujal-2820 commented 11 months ago

Actually @Sujal-2820 is the main account of mine. I have actually connected my github desktop to @Sujal-12345.

But the contribution counts from @Sujal-2820 only 😅

I am glad you liked it. Thanks!

divyanshudhruv commented 11 months ago

Will merge it soon

Sujal-2820 commented 11 months ago

Sure 👍 Thank you so much!!

divyanshudhruv commented 11 months ago

Congrats @Sujal-2820

Sujal-2820 commented 11 months ago

Wooh!!🚀 Thanks @divyanshudhruv for your support