No checks to ensure segment proof ends in root node - Githubissues

diwakergupta / stacks-blockchain-tob-audit

GNU General Public License v3.0

0 stars 0 forks source link

No checks to ensure segment proof ends in root node #5

Open blperez01 opened 4 years ago

blperez01 commented 4 years ago

In chainstate/stacks/index/proofs.rs, the function is_proof_well_formed claims to check for the following properties in a potential segment proof

it must have the same number of segment and shunt proofs
segment proof i+1 must be a prefix of segment proof i
segment proof 0 must end in a leaf
all segment proofs must end in a Node256 (a root)

However, the function does not check that segment proofs end in a Node256.

jcnelson commented 4 years ago

This is a bug; will fix.