search

diwako / diwako_cbrn

Arcadey CBRN mechanics
Other
21 stars 10 forks source link

Fogging #4

Closed CuteMoonGod closed 2 years ago

CuteMoonGod commented 2 years ago

Removed commented out code Fixed values to intended defaults Fixed fog built up calc so that the AC coef also reduces fog build up due to fatigue

CuteMoonGod commented 2 years ago

Wrong *repo, my bad

diwako commented 2 years ago

Hey as long as it becomes a pr in the future i guess ¯_(ツ)_/¯

CuteMoonGod commented 2 years ago

Alright then 😄 Reopening. Feel free to tell me if there's thing that need changing =)

diwako commented 2 years ago

probably best to make a new pr with the changes from your master. I however straight away say the fogging feature is a neat idea, i totally forgot that was a thing. guess i blanked it out of my mind when i had respirator gear training, i hated that a lot.

The geiger counter is also a neat idea, tho i would prefer to have the beep option still. For code improvements ( i already spied a little, ngl) i have some suggestions but that would be for the new pr.

CuteMoonGod commented 2 years ago

Will do.