search

diwako / diwako_cbrn

Arcadey CBRN mechanics
Other
21 stars 10 forks source link

Merge with Fogging, Geiger, etc. #5

Closed CuteMoonGod closed 2 years ago

CuteMoonGod commented 2 years ago

As requested, a new PR from my master 😄

To clarify, I didn't remove the beeping functionality, it's still on the Chemical detector.

As you mentioned some possible improvements, fire away! Eager to learn this is my first "proper" SQF project.

diwako commented 2 years ago

Wanted to ask what the status of this is.

CuteMoonGod commented 2 years ago

Hey, I've been extremely busy with work and IRL stuff. I'm gonna write down what I intend to do in the issues themselves and hammer them out over the weekend.

diwako commented 2 years ago

Hey, no rush. That is completely fine, i felt the need to ask as usually if a pr stops it becomes abandoned fairly quickyl. in that case i would have taken over.

diwako commented 2 years ago

Do tell once this is ready for review

CuteMoonGod commented 2 years ago

Ready for review :)

diwako commented 2 years ago

LGTM there are some pet peeves which i will change myself if that is fine with you. I will then push those onto your branch directly.

CuteMoonGod commented 2 years ago

Cool, feel free to, happy to have been of help

diwako commented 2 years ago

There. Feel free to poke holes in it.

diwako commented 2 years ago

I also see you changed your username on github. which name should i use when I make the release? Same as the author name in the readme or your current github username?

CuteMoonGod commented 2 years ago

Either is fine, CuteMoonGod I use mostly when Celene is already taken :) Other than that, LGTM! The max Alpha is a really nice idea actually

diwako commented 2 years ago

Thank you, i will be testing a bit more and see if i find something to change, then will release a version and announce in the BI thread.