diwic / dbus-rs

D-Bus binding for the Rust language
Other
589 stars 133 forks source link

dbus-codegen: When crossroads is enabled, no client-side code is generated #437

Closed Snarpix closed 1 year ago

Snarpix commented 1 year ago

Currently if I specify:

let opts = dbus_codegen::GenOpts {
        crossroads: true,
        methodtype: None,
        ..Default::default()
    };

Then no impl trait for Proxy is generated. Can I create a PR, that allows both server and client code to be generated? Or this is design decision?

diwic commented 1 year ago

It could be that the ability was removed because the interface for client code and crossroads code does not look exactly the same. E g, different Error types or something like that, IIRC. So it might not be as easy as you think to enable it. But if it's possible then I'm all for it.

diwic commented 1 year ago

Closing due to inactivity

Snarpix commented 1 year ago

Yes, you are correct, it's easier to generate separate files.