diwic / dbus-rs

D-Bus binding for the Rust language
Other
585 stars 131 forks source link

Adding procedural macros #459

Open eaglesemanation opened 6 months ago

eaglesemanation commented 6 months ago

Adds multiple derive macros for implementing Arg, Get and Append traits combined. Makes it much less cumbersome to translate between dbus structs and rust structs. More details in this discussion: https://github.com/diwic/dbus-rs/discussions/456

diwic commented 6 months ago

In addition, the tests fail so that needs to be fixed before merging also.

diwic commented 3 months ago

@eaglesemanation Hi, how are things going? This is a really interesting PR, but once merged, I'm going to need your assistance with maintaining it, since procedural macros is not my area of expertise. If you're unavailable for long periods of time, that makes me a bit uneasy.

eaglesemanation commented 3 months ago

Hey, sorry, life happened. First my dad came from overseas, needed to spend time with him, no clue when I'll meet him again. Now my employee wants me to relocate, and I need to make a decision pretty soon. I really hope I'll get more time soon to get back to this, but I'm not 100% curtain. If you're not comfortable with that - I could keep this as a separate crate, so any issues reported would be addressed to me

diwic commented 3 months ago

Hey, sorry, life happened. First my dad came from overseas, needed to spend time with him, no clue when I'll meet him again. Now my employee wants me to relocate, and I need to make a decision pretty soon. I really hope I'll get more time soon to get back to this, but I'm not 100% curtain. If you're not comfortable with that - I could keep this as a separate crate, so any issues reported would be addressed to me

No worries. Life happens to all of us from time to time :-) Let me know how things are progressing and if/when you're more available again, we can have another shot at the upstreaming.