search

dixonandmoe / rellax

Lightweight, vanilla javascript parallax library
https://dixonandmoe.com/rellax/
MIT License
7.06k stars 878 forks source link

Round off #198

Open ghost opened 4 years ago

ghost commented 4 years ago

If speed > 10 speed should be rounded off to 10 same for negative values

p-realinho commented 3 years ago

This was done in the past but was removed at some point. Not sure why that decision was made. Maybe @benface can weigh in on this?

benface commented 3 years ago

Haha I don't remember why I did that. Maybe I liked the effect of a speed above 10 or under -10 in a project I was working on? But I mean in general, it seems like an arbitrary limit. Can't we trust that the developer knows what they're doing? A speed value outside these bounds doesn't necessarily break anything, does it?

ghost commented 3 years ago

Keep limits, if not they'll pass Infinity , BigInt etc,