search

diyabc / diyabcGUI

User interface to DIYABC/AbcRanger
https://diyabc.github.io/
Other
4 stars 2 forks source link

Question about scenario compatibility with data set #132

Closed gdurif closed 2 years ago

gdurif commented 2 years ago

Expected behavior: a scenario is compatible with the data set if the number of populations sampled at t=0 is equal to the number of populations in the dataset.

Contradiction with TOY EXAMPLE 1: scenario with total number of sample equal to the number of populations in the dataset.

FIXME: line 520 in R-pkg/R/21_historical_model.R

gdurif commented 2 years ago

Temp fix in 9158525

Chosen approach: a scenario is compatible with the data set if the total number of sample is equal to the number of populations in the dataset, which allow sampling in the past.

gdurif commented 2 years ago

45092b9 answers the question about compatibility between scenario and dataset: the total number of samples in the scenario should correspond to the total number of populations in the dataset (allowing sampling in the past)