Windows standalone build

diyabc / diyabcGUI

User interface to DIYABC/AbcRanger

https://diyabc.github.io/

Other

4 stars 2 forks source link

Windows standalone build #20

Closed gdurif closed 3 years ago

gdurif commented 4 years ago

run build_standalone.R (based on R package electricShine)
If 1. not working, try running build_standalone_windows.R (based on R package RInno)

fradav commented 4 years ago

Both scripts fails with :

package 'rlang' successfully unpacked and MD5 sums checked
Erreur : (converti depuis l'avis) cannot remove prior installation of package 'rlang'
Exécution arrêtée

gdurif commented 4 years ago

build_standalone.R with electricShine worked, c.f. https://github.com/diyabc/diyabcGUI/releases/tag/v1.0

In the future, we might want to switch to build_standalone_windows.R (potential cleaner build)

fradav commented 4 years ago

Apparently the standalone is missing a few key DLL for the included binaries to work on a "vanilla" windows :

libiomp5md.dll (openmp library used by diyabc, distributed with intel mkl installation)
vcruntime140_1.dll (microsoft c++ redistributable). I make two separate issues about this

fradav commented 4 years ago

https://github.com/diyabc/abcranger/issues/64 https://github.com/diyabc/diyabc/issues/36

As a side note, we should have a "vanilla" windows VM (as a snapshot for example) to test this.

fradav commented 4 years ago

Good news, I can reproduce the problems in a windows vm.

fradav commented 4 years ago

It is completely fixed for abcranger latest release. However, for diyabc exe, the choice of openmp as multithreading backend forces us to deploy the windows binary with two dlls (included in the release page) vcomp140.dll and vcruntime140.dll : there is no workaround, sorry.

gdurif commented 3 years ago

TODO

diyabc executable detected as threat and blocked by windows (https://github.com/diyabc/diyabc/issues/40)
find a way to make the installer considered as safe by Windows (blocked by Edge at download and by Windows at install)
find an alternative to electricShine to only wrap R and package dependencies inside the binary and not a pseudo-browser, i.e. the standalone would run diabcGUI::diyabc() and open the app in the host web-browser.

gdurif commented 3 years ago

Change of plan and new strategy based on DesktopDeployR: see 4178965

TODO:

fix issue with log files
fix issue when running multiple instances simultaneously

gdurif commented 3 years ago

TODO fixed in current release (4fd8d59).

gdurif commented 3 years ago

New standalone release strategy based on DesktopDeployR is now running smoothly.

See build/README.d and build/DesktopDeployR/README.md for more details and instructions.