search

diyabc / diyabcGUI

User interface to DIYABC/AbcRanger
https://diyabc.github.io/
Other
4 stars 2 forks source link

[historical model display] issue with unsampled population #67

Closed gdurif closed 3 years ago

gdurif commented 3 years ago

Valid scenario:

N N
0 sample 1
0 sample 2
t merge 1 2

Buggy scenario:

N N N3
0 sample 1
0 sample 2
t3 merge 2 3
t merge 1 2

Following error

Error in if: missing value where TRUE/FALSE needed
  75: tree2node_coordinate [/xxx/diyabcGUI/R-pkg/R/22_historical_model_display.R#382]
  74: prepare_hist_model_display [/xxx/diyabcGUI/R-pkg/R/22_historical_model_display.R#596]
  73: observeEventHandler [/xxx/diyabcGUI/R-pkg/R/21_historical_model.R#89]
   2: shiny::runApp
   1: diyabc [/xxx/diyabcGUI/R-pkg/R/diyabc.R#14]
gdurif commented 3 years ago

Fixed in 08025e5

Should be in next release (>1.0.11)