search

diyhue / Lights

DIY lights with support for diyHue
https://diyhue.org/
172 stars 97 forks source link

Copied the HTML string from Generic_WS2812 and implemented in Generic_SK6812 #103

Closed GHBLoos closed 3 years ago

GHBLoos commented 3 years ago

This is my first pull request, so completely new to this process.

Since the webpage of a generic_SK6812 was different from the generic_WS2812, I thought I change it to make it the same.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 2 days if no further activity occurs. Thank you for your contributions.

juanesf commented 3 years ago

This is stale?

mariusmotea commented 3 years ago

Thanks for you work. I need to check if all settings are implemented in SK6812 sketch, but that settings values will be ignored, so nothing can be broken.

GHBLoos commented 3 years ago

Red , green and blue multiplier isn't stored and recovered as far as I know. And I don't think it is even used in the (entertainment) code.