search

diyhue / Lights

DIY lights with support for diyHue
https://diyhue.org/
172 stars 97 forks source link

Manual division of the lights for SK6812 strip #110

Closed DarthAnwalt closed 3 years ago

DarthAnwalt commented 3 years ago

Hi! First of all, many thanks for your work, project is absolutely awesome.

I'm using SK6812 strip, and it looks like the dividible lights (pixels) function, which were added by @dobby5 to Generic_WS2812_Strip.ino sketch, is absent in Generic_SK6812_Strip.ino. So, user can't manually choose number of leds for every virtual light with SK6812 light strip.

I tried to implement @dobby5 's code from Generic_WS2812_Strip.ino to Generic_SK6812_Strip.ino and tested result for successfully compiling and working with real hardware. Could you please review this changes and, if all is right, update Generic_SK6812_Strip.ino in master branch.

Best regards! Generic_SK6812_Strip[1].txt

mariusmotea commented 3 years ago

Hi,

Thanks for your work!. If you test this and is working good, please fork this repo, commit the changes to this file and create Pull Request to master, so your contribution will be recorded.

DarthAnwalt commented 3 years ago

Ok, did it. I'm new to Github, so I'm still learning how to use it.

Thanks for your reply!