Closed panovvv closed 3 years ago
Hi,
I think both 2 and 3 options are fine, important is to have good structure so the users will not be have issues to understand which pcb/cad is for witch sketch. Probably soon there will be some cleanup with the release of the Dynamic Scenes.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 2 days if no further activity occurs. Thank you for your contributions.
I've been wanting to contribute these schematics, PCBs, and 3d models for quite a while, but couldn't settle on a best way to go about it. The following options have been considered: 1) Plain copy from esp8266-lighting-controllers repo to Lights repo. Pro: easiest of the options, Con: leaves us with 2 copies of the same files, that are bound to wildly diverge from one another eventually. 2) Include esp8266-lighting-controllers as a submodule into Lights repo. Pro: clear ownership distribution (I still maintain my repo, diyHue folks maintain the Lights repo), Con: more complicated to manage than plain git repo. 3) Link to esp8266-lighting-controllers from the Lights repo - this is what I eventually settled on. The only disadvantage I can think of is that this will look like a shameless self-plug lol :)
Please chime in - which of the options do you guys prefer, I'd be happy to accommodate this PR to the way you run things in diyHue.