diyhue / Lights

DIY lights with support for diyHue
https://diyhue.org/
172 stars 97 forks source link

sync WS2812 changes & implement RGB to RGBW for SK6812 #129

Closed zhuoyang closed 2 years ago

zhuoyang commented 2 years ago

Initial implementation, need to hard code white color temperature RGB value, maybe make it configurable in the web interface? Closes #127

mariusmotea commented 2 years ago

Thanks.

I think it will be complicated to add white balance in the web interface. I don't expect to have big differences from one vendor to another on leds color levels.

zhuoyang commented 2 years ago

The shop I bought my SK6812 has 3 variant for the white LED (warm, cool and natural), so I think it's good to have it configurable, but this is good enough for now.

mariusmotea commented 2 years ago

Only natural can be used i think. The white led is too powerful in order to be used if is not neutral white. I think we need a toggle switch to enable/disable the use of the white leds in combination with the color leds for the users who don't own the neutral white model can still get good colors without the white leds.

zhuoyang commented 2 years ago

There's a color correction implemented so it can be used for any white, but the RGB value of the white need to be configured according to the color temperature (https://andi-siess.de/rgb-to-color-temperature/) For now it's hard coded to 3000K now because that's what I have.

RGB to color temperature – Andreas Siess
mariusmotea commented 2 years ago

For the moment i think we can put in the header of the sketch the three options (warm white, cold white and neutral white) and have just the most common uncommented lines (i think neutral white is the most used). After that i will merge it and generate the firmware file for bin folder.

Thanks!

mariusmotea commented 2 years ago

Thanks for your contribution!

Paalap commented 1 year ago

@mariusmotea did you had any progress on this development?