diyhue / Lights

DIY lights with support for diyHue
https://diyhue.org/
172 stars 97 forks source link

Fixed blending algorithm for transition leds #130

Closed landler closed 1 year ago

landler commented 1 year ago

The blending algorithm for the transition leds of divided lights had a math error, causing it to always return a brightness exactly half of what it should be. This caused the transitions between two colors to be too dim, easiest seen on very low brightnesses (e.g. Nightlight of the default Hue modes).

Before: 20220908_211644

After: 20220908_225334

(It looks a bit different due to different exposure, but point being that it's uniform now)

mariusmotea commented 1 year ago

Thanks for fixing this.

Burn-In commented 1 year ago

@landler Good job. Thanks. This one bothered me for a long time.

But, you should also remove it in RgbColor blendingEntert(). This function always run for me.

_