Update Generic_WS2812_Strip.ino

diyhue / Lights

DIY lights with support for diyHue

https://diyhue.org/

172 stars 97 forks source link

Update Generic_WS2812_Strip.ino #142

Closed Paalap closed 1 year ago

Paalap commented 1 year ago

Updating transition - there was an issue on remainig led after turning lights off one by one. (also some rework on transition logic overall)

mariusmotea commented 1 year ago

Hi,

Thanks for your work! Did you test the changes of Generic_WS2812_Strip with 1, 2 and 3 segments to see if the transition leds behave normally in all 3 scenarios ?

Paalap commented 1 year ago

Yes, it is working well with all my test scenarios

mariusmotea commented 1 year ago

great!

Burn-In commented 1 year ago

Hi there, unfortunately the transision effect don't work very well within entertainment mode. Not only the unnecessary by 2 devider in blendingEntert(), which makes the transition LEDs darker, still exists. Also the whole transition sometimes don't work and there is no transition between lights. My code based on an old WS2812BHueStrip.ino and, after removing /2, the transition looks as expected. WS2812BHueStrip.zip

Paalap commented 1 year ago

Hi, not sure but in the updated code there is no blendingEnt more. And to be honest my focus was more on normal use, but entertainment test scenario worked fore also well

Burn-In commented 1 year ago

My apologies, it seems that I still was on a previous version. Your hint causes me to compare my used code again. Now I can confirm that everything works very well including the entertainment mode . No blending issues. Sorry and thanks for your work.