search

diyhue / hassio-addon

35 stars 11 forks source link

Can't disable the HTTPS port #5

Closed foxy82 closed 2 years ago

foxy82 commented 2 years ago

Before the rewrite of diyhue we could run diyhue with --no-serve-https so that the HTTPS server isn't started.

In the addon the parameter can still be set but it is ignored.

It looks like we need to add it as an env variable in run.sh and then in HueEmulator3.py we need to get that environment variable and add an if around the line that creates the HTTPS port.

At alternative (and possibly better) solution would be to make the HTTP / HTTPS ports configurable this is important as the addon runs in host network mode.

foxy82 commented 2 years ago

Submitted a PR to remove the unused (I believe) port config and instead make the http / https ports configurable. Please can you take a look at / test. It mostly works for me except I think the Home Assistant connection isn't working perfectly... with the Hue app I often get "connecting" appearing. However using hue essentials it does work - I assume this isn't related to the change and is more related to the Home Assistant connection but it would be good to get confirmation.

Mevel commented 2 years ago

17cfc30

Was merged.

HA issue is looked into