search

dizda / CloudBackupBundle

Be able to backup your database(s) and upload it to the cloud (Dropbox, Amazon S3, GoogleDrive, etc.)
MIT License
196 stars 57 forks source link

Add support for mysql 5.6.x. #107

Closed yamilovs closed 7 years ago

yamilovs commented 8 years ago

It will fix this warning: "Warning: Using a password on the command line interface can be insecure."

yamilovs commented 8 years ago

And i found one issue, that mysql.cnf configuration file was dumped with all requsites to backup file. I think it is not good. I'll try to fix this soon.

yamilovs commented 8 years ago

Hello! I made some changes in MySQL dump structure. Some constructor refactoring, and now removing file with connect requsites from database dump. Can u check it?

yamilovs commented 7 years ago

@Nyholm Hello, Tobias. Do u have any progress on this PR? Thanks in advance. PS. We want to use this bundle on our PHP7 project, but it doesn't work correctly on MySQL 5.6. Of course i can create a fork, but i think it is not a good idea =)

Nyholm commented 7 years ago

Sorry for being slow on getting back on this PR. I'll test and review it this week.

PS. We want to use this bundle on our PHP7 project, but it doesn't work correctly on MySQL 5.6. Of course i can create a fork, but i think it is not a good idea =)

Please make PRs and I (or someone) will review it. We want to support PHP7.

dizda commented 7 years ago

Hello, personally we don't have any problems with PHP7+MariaDB and this bundle. The issue might be related directly to MySQL5.6.

Just one question, why do you have the mysql.cnf in your backup files? I don't get it.

yamilovs commented 7 years ago

Hello, @dizda. mysql.cnf was in 60af855 commit. I fixed this issue in 8e231ee.

Nyholm commented 7 years ago

Could you rebase on master so Travis will have a change to show green?

yamilovs commented 7 years ago

Ok, guys, all done!

dizda commented 7 years ago

Ok, much more clear and secure! Thanks.

Last thought, do you remove the file mysql.cnf in the case when an Exception happened? Because that would be un-secure to leave this file on the server.

yamilovs commented 7 years ago

If exception occurs, it will be handle with execute() function in manager/BackupManager, that remove all backup directory with mysql.cnf file too.

dizda commented 7 years ago

Sweet, let's do it then!

dizda commented 7 years ago

Thanks, https://github.com/dizda/CloudBackupBundle/releases/tag/3.4.0 released.